You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ignite.apache.org by am...@apache.org on 2019/03/13 10:02:47 UTC

[ignite] branch master updated: IGNITE-11079: MVCC: IgniteCacheContinuousQueryBackupQueueTest is flacky. This closes #6249.

This is an automated email from the ASF dual-hosted git repository.

amashenkov pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ignite.git


The following commit(s) were added to refs/heads/master by this push:
     new 2aa5341  IGNITE-11079: MVCC: IgniteCacheContinuousQueryBackupQueueTest is flacky. This closes #6249.
2aa5341 is described below

commit 2aa53414bb362debcc997c0a571d6e084949f8f4
Author: rkondakov <ko...@mail.ru>
AuthorDate: Wed Mar 13 13:02:25 2019 +0300

    IGNITE-11079: MVCC: IgniteCacheContinuousQueryBackupQueueTest is flacky. This closes #6249.
---
 .../continuous/IgniteCacheContinuousQueryBackupQueueTest.java      | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/query/continuous/IgniteCacheContinuousQueryBackupQueueTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/query/continuous/IgniteCacheContinuousQueryBackupQueueTest.java
index 34273b6..090291d 100644
--- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/query/continuous/IgniteCacheContinuousQueryBackupQueueTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/query/continuous/IgniteCacheContinuousQueryBackupQueueTest.java
@@ -169,8 +169,11 @@ public class IgniteCacheContinuousQueryBackupQueueTest extends GridCommonAbstrac
 
         int size = backupQueueSize();
 
-        assertTrue(size > 0);
-        assertTrue(size <= BACKUP_ACK_THRESHOLD * QUERY_COUNT * /* partition count */1024);
+        // Backup queues total size should not exceed one entry per query per partition. This is because
+        // {@link CacheContinuousQueryEventBuffer} is optimized to store filtered events and
+        // used in this test {@link AlwaysFalseFilterFactory} always declines updates.
+        // Zero total size is possible when backup queue is cleaned by timeout.
+        assertTrue(size <= QUERY_COUNT * /* partition count */1024);
 
         for (QueryCursor qry : qryCursors)
             qry.close();