You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/10 04:24:09 UTC
[GitHub] [arrow] jianxind opened a new pull request #7700: ARROW-9398: [C++] Register SIMD sum variants to function instance.
jianxind opened a new pull request #7700:
URL: https://github.com/apache/arrow/pull/7700
Enable simd_level feature of kernel and use it in DispatchExactImpl.
Also expand sum/mean test case to cover BitBlockCounter method.
Signed-off-by: Frank Du <fr...@intel.com>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jianxind commented on pull request #7700: ARROW-9398: [C++] Register SIMD sum variants to function instance.
Posted by GitBox <gi...@apache.org>.
jianxind commented on pull request #7700:
URL: https://github.com/apache/arrow/pull/7700#issuecomment-656479567
Follow up https://github.com/apache/arrow/pull/7607, delegate the SIMD dispatch to kernel level inside the function instance. @wesm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jianxind commented on pull request #7700: ARROW-9398: [C++] Register SIMD sum variants to function instance.
Posted by GitBox <gi...@apache.org>.
jianxind commented on pull request #7700:
URL: https://github.com/apache/arrow/pull/7700#issuecomment-666042625
> Follow up #7607, delegate the SIMD dispatch to kernel level inside the function instance. @wesm
@wesm @pitrou @emkornfield Ping, could you help to review this when you are available? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7700: ARROW-9398: [C++] Register SIMD sum variants to function instance.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7700:
URL: https://github.com/apache/arrow/pull/7700#issuecomment-656476370
https://issues.apache.org/jira/browse/ARROW-9398
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #7700: ARROW-9398: [C++] Register SIMD sum variants to function instance.
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #7700:
URL: https://github.com/apache/arrow/pull/7700#issuecomment-656481223
[AMD64 Ubuntu 18.04 C++ Benchmark (#118393)](https://ci.ursalabs.org/#builders/73/builds/94) builder failed.
Revision: 7c449cee21e96ae22979c159c053b954cb482047
Archery: `'archery benchmark ...'` step's stderr:
```
Using optional gold linker (version 1.15)
Configured for RELEASE build (set with cmake -DCMAKE_BUILD_TYPE={release,debug,...})
Building Apache Thrift from source
CMake Warning at cmake_modules/ThirdpartyToolchain.cmake:152 (find_package):
No "Findbenchmark.cmake" found in CMAKE_MODULE_PATH.
Call Stack (most recent call first):
cmake_modules/ThirdpartyToolchain.cmake:1721 (resolve_dependency)
CMakeLists.txt:484 (include)
CMake Warning (dev) at cmake_modules/ThirdpartyToolchain.cmake:152 (find_package):
Findbenchmark.cmake must either be part of this project itself, in this
case adjust CMAKE_MODULE_PATH so that it points to the correct location
inside its source tree.
Or it must be installed by a package which has already been found via
find_package(). In this case make sure that package has indeed been found
and adjust CMAKE_MODULE_PATH to contain the location where that package has
installed Findbenchmark.cmake. This must be a location provided by that
package. This error in general means that the buildsystem of this project
is relying on a Find-module without ensuring that it is actually available.
Call Stack (most recent call first):
cmake_modules/ThirdpartyToolchain.cmake:1721 (resolve_dependency)
CMakeLists.txt:484 (include)
This warning is for project developers. Use -Wno-dev to suppress it.
Cloning into '/tmp/arrow-archery-6hiigc3a/origin_master/arrow'...
done.
Note: checking out '2596b3419f2bb03ba9ecbdd3d4fbd521232157bc'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:
git checkout -b <new-branch-name>
HEAD is now at 2596b3419 ARROW-9384: [C++] Avoid memory blowup on invalid IPC input
Using optional gold linker (version 1.15)
Configured for RELEASE build (set with cmake -DCMAKE_BUILD_TYPE={release,debug,...})
Building Apache Thrift from source
CMake Warning at cmake_modules/ThirdpartyToolchain.cmake:152 (find_package):
No "Findbenchmark.cmake" found in CMAKE_MODULE_PATH.
Call Stack (most recent call first):
cmake_modules/ThirdpartyToolchain.cmake:1721 (resolve_dependency)
CMakeLists.txt:484 (include)
CMake Warning (dev) at cmake_modules/ThirdpartyToolchain.cmake:152 (find_package):
Findbenchmark.cmake must either be part of this project itself, in this
case adjust CMAKE_MODULE_PATH so that it points to the correct location
inside its source tree.
Or it must be installed by a package which has already been found via
find_package(). In this case make sure that package has indeed been found
and adjust CMAKE_MODULE_PATH to contain the location where that package has
installed Findbenchmark.cmake. This must be a location provided by that
package. This error in general means that the buildsystem of this project
is relying on a Find-module without ensuring that it is actually available.
Call Stack (most recent call first):
cmake_modules/ThirdpartyToolchain.cmake:1721 (resolve_dependency)
CMakeLists.txt:484 (include)
This warning is for project developers. Use -Wno-dev to suppress it.
2020-07-10 04:52:27
Running /tmp/arrow-archery-6hiigc3a/WORKSPACE/build/release/arrow-compute-aggregate-benchmark
Run on (40 X 3600 MHz CPU s)
CPU Caches:
L1 Data 32 KiB (x20)
L1 Instruction 32 KiB (x20)
L2 Unified 256 KiB (x20)
L3 Unified 51200 KiB (x1)
Load Average: 105.69, 43.12, 22.53
***WARNING*** CPU scaling is enabled, the benchmark real time measurements may be noisy and will incur extra overhead.
Traceback (most recent call last):
File "/usr/local/bin/archery", line 11, in <module>
load_entry_point('archery', 'console_scripts', 'archery')()
File "/usr/local/lib/python3.6/dist-packages/click/core.py", line 764, in __call__
return self.main(*args, **kwargs)
File "/usr/local/lib/python3.6/dist-packages/click/core.py", line 717, in main
rv = self.invoke(ctx)
File "/usr/local/lib/python3.6/dist-packages/click/core.py", line 1137, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/local/lib/python3.6/dist-packages/click/core.py", line 1137, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/local/lib/python3.6/dist-packages/click/core.py", line 956, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/usr/local/lib/python3.6/dist-packages/click/core.py", line 555, in invoke
return callback(*args, **kwargs)
File "/usr/local/lib/python3.6/dist-packages/click/decorators.py", line 17, in new_func
return f(get_current_context(), *args, **kwargs)
File "/buildbot/AMD64_Ubuntu_18_04_C___Benchmark/dev/archery/archery/cli.py", line 573, in benchmark_diff
comparisons_json = _get_comparisons_as_json(runner_comp.comparisons)
File "/buildbot/AMD64_Ubuntu_18_04_C___Benchmark/dev/archery/archery/cli.py", line 581, in _get_comparisons_as_json
for comparator in comparisons:
File "/buildbot/AMD64_Ubuntu_18_04_C___Benchmark/dev/archery/archery/benchmark/compare.py", line 166, in comparisons
for suite_name, (suite_cont, suite_base) in suites:
File "/buildbot/AMD64_Ubuntu_18_04_C___Benchmark/dev/archery/archery/benchmark/compare.py", line 141, in pairwise_compare
dict_contender = {e.name: e for e in contender}
File "/buildbot/AMD64_Ubuntu_18_04_C___Benchmark/dev/archery/archery/benchmark/compare.py", line 141, in <dictcomp>
dict_contender = {e.name: e for e in contender}
File "/buildbot/AMD64_Ubuntu_18_04_C___Benchmark/dev/archery/archery/benchmark/runner.py", line 199, in suites
suite = self.suite(suite_name, suite_bin)
File "/buildbot/AMD64_Ubuntu_18_04_C___Benchmark/dev/archery/archery/benchmark/runner.py", line 176, in suite
results = suite_cmd.results(repetitions=self.repetitions)
File "/buildbot/AMD64_Ubuntu_18_04_C___Benchmark/dev/archery/archery/benchmark/google.py", line 63, in results
self.run(*argv, check=True)
File "/buildbot/AMD64_Ubuntu_18_04_C___Benchmark/dev/archery/archery/utils/command.py", line 74, in run
return subprocess.run(invocation, **kwargs)
File "/usr/lib/python3.6/subprocess.py", line 438, in run
output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['/tmp/arrow-archery-6hiigc3a/WORKSPACE/build/release/arrow-compute-aggregate-benchmark', '--benchmark_repetitions=1', '--benchmark_out=/tmp/tmpvm40xw5y', '--benchmark_out_format=json']' died with <Signals.SIGILL: 4>.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm closed pull request #7700: ARROW-9398: [C++] Register SIMD sum variants to function instance.
Posted by GitBox <gi...@apache.org>.
wesm closed pull request #7700:
URL: https://github.com/apache/arrow/pull/7700
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #7700: ARROW-9398: [C++] Register SIMD sum variants to function instance.
Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #7700:
URL: https://github.com/apache/arrow/pull/7700#issuecomment-666105439
@jianxind I think @wesm is probably the best person review and I think he'll be back online full time next week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7700: ARROW-9398: [C++] Register SIMD sum variants to function instance.
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7700:
URL: https://github.com/apache/arrow/pull/7700#issuecomment-666739557
I rebased just to make sure that the Appveyor failure is transient
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jianxind commented on pull request #7700: ARROW-9398: [C++] Register SIMD sum variants to function instance.
Posted by GitBox <gi...@apache.org>.
jianxind commented on pull request #7700:
URL: https://github.com/apache/arrow/pull/7700#issuecomment-656480294
@ursabot benchmark --suite-filter=arrow-compute-aggregate-benchmark
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org