[GitHub] [skywalking] kezhenxu94 edited a comment on issue #7553: Create skywalking-java-commons sub project

[GitBox <gi...@apache.org>]

kezhenxu94 edited a comment on issue #7553:
URL: https://github.com/apache/skywalking/issues/7553#issuecomment-904640789


   What I concern is, having this new sub repo will increase the maintainers' load, (not about maintaining codes, I mean releasing new versions)
   
   > We could do share nothing, and copy them into agent and backend core if we want, actually. If duplicate is not a concern.
   
   In fact we don't need to "copy", we just push the original repo to the new agent repo, and delete everything that is not needed in the repo itself.
   
   And according to https://github.com/apache/skywalking/issues/7553#issuecomment-904629858
   
   > I also checked classes in apm-util, only PropertyPlaceholderHelper is really shared between oap-server and agent, other classes are either only used in agent or oap-server, we can move them into agent or oap-server codebase respectively.
   
   As for the other module `apm-datacarrier`, I think we can leave it in 2 repos until we have time to replace it with Disruptor (we discussed this before, with @CalvinKirs, and I'm glad to do that when I have time).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org