You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/07/27 01:15:08 UTC

[GitHub] [incubator-apisix] spacewander commented on a change in pull request #1910: bugfix: should not save the runtime data of plugin into `etcd`.

spacewander commented on a change in pull request #1910:
URL: https://github.com/apache/incubator-apisix/pull/1910#discussion_r460601114



##########
File path: apisix/core/json.lua
##########
@@ -26,6 +27,7 @@ local cached_tab = {}
 local _M = {
     version = 0.1,
     decode = require("cjson.safe").decode,
+    sort_encode = require("apisix.core.json_sort").encode,

Review comment:
       Better to use name `encode_with_keys_sorted`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org