[jira] [Commented] (KNOX-547) Topology Validation in Knox CLI

["Kevin Minder (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KNOX-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14564929#comment-14564929 ] 

Kevin Minder commented on KNOX-547:
-----------------------------------

Hey [~zacblanco], some feedback about KNOX-547-2.patch
* ant verify failed for me after applying the patch
* Please add an entry to the CHANGES file for this New Feature.  You will need to add a 0.7.0 section too.
* gateway-server/src/main/resources/conf/topologies/admin.xml
** I don't think this test file should be in the "main" source branch.
* gateway-server/src/main/java/org/apache/hadoop/gateway/util/KnoxCLI.java
** I'd prefer that the scheme be loaded from the classpath via  Schema s = fact.newSchema( ClassLoader.getSystemResource( "conf/topology-v1.xsd" ) );
* gateway-server/src/main/resources/conf/topologies/sandbox.xml
** I don't think this test file should be in the "main" source branch.
* gateway-release/home/conf/Topology.xsd
** I don't think this file is necessary.  The one in gateway-server should be sufficient if loaded from the classpath.  This will avoid upgrade issues.
* gateway-server/src/main/resources/conf/Topology.xsd
** Please rename this to topology-v1.xsd and see the note about loading it from the class path in KnoxCLI.java
* gateway-server/src/test/resources/conf-demo/conf/Topology.xsd
** I don't think this file is necessary.

> Topology Validation in Knox CLI
> -------------------------------
>
>                 Key: KNOX-547
>                 URL: https://issues.apache.org/jira/browse/KNOX-547
>             Project: Apache Knox
>          Issue Type: New Feature
>          Components: KnoxCLI
>            Reporter: Zachary Blanco
>            Assignee: Zachary Blanco
>            Priority: Minor
>         Attachments: KNOX-547-2.patch, KNOX-547.patch
>
>
> Topology configuration or misconfiguration are common support cases and pain points for users of Knox.
> Create a new command in the Knox CLI utility to check the validity of a topology file.
> Not specifying /path/to/file could default to /etc/knox/conf/topologies/default.xml.
> This feature should allow a user to test the syntax of a topology file, a "shallow" validation. It does not have to check the validity of the contents.
> This feature would also become part of the Knox support checklist in support and would speed up time to resolution when.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)