You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/20 08:19:19 UTC
[GitHub] [incubator-superset] graceguo-supercat opened a new pull request #10115: fix: dashboard should not add extra_filters onto chart annotation
graceguo-supercat opened a new pull request #10115:
URL: https://github.com/apache/incubator-superset/pull/10115
### SUMMARY
We used to be able to show filtered vs all data in the same chart by using annotation. See below is an example, region vs global.
But I recently found there was an issue introduced by #8057, where dashboard filter (**extra_filters** param) is applied to chart's annotation layer. This will cause chart and annotation layer both have same query, so we can't compare filtered data vs original annotation layer.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
**before:**
<img width="1264" alt="Screen Shot 2020-06-20 at 1 02 36 AM" src="https://user-images.githubusercontent.com/27990562/85197001-f397c280-b292-11ea-930c-eea241c01981.png">
**after:**
<img width="1263" alt="Screen Shot 2020-06-20 at 1 06 17 AM" src="https://user-images.githubusercontent.com/27990562/85197002-f692b300-b292-11ea-89d9-ccca267787f0.png">
### TEST PLAN
Manual test
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: #8057
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat merged pull request #10115: fix: dashboard should not add extra_filters onto chart annotation
Posted by GitBox <gi...@apache.org>.
graceguo-supercat merged pull request #10115:
URL: https://github.com/apache/incubator-superset/pull/10115
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org