You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by fhueske <gi...@git.apache.org> on 2014/12/12 15:29:35 UTC
[GitHub] incubator-flink pull request: [FLINK-1318] CsvInputFormat: Made qu...

GitHub user fhueske opened a pull request:

    https://github.com/apache/incubator-flink/pull/265

    [FLINK-1318] CsvInputFormat: Made quoted string parsing optional with configurable quote character. Simplified parsing

    - Parsing of quoted strings is disabled by default
    - When enabling a quoting character needs to be specified
    - If quoting parsing is enabled, Strings are parsed as quoted if the first character is the quoting character (leading and tailing whitespace characters are NOT ignored)
    - If quoting parsing is enabled and the first character is NOT the quoting character, Strings are treated as unquoted
    - Quoted parsing fails 1) if the last character of the field ist NOT the quote character (tailing characters), or 2) the closing quote character is missing
    
    This mode of operation differs from the previous implementation:
    - Leading and tailing characters were ignored in case of quoted strings but would have caused problems if whitespaces were used as field delimiters.
    - double quote characters could be used to escape quotes in quoted strings
    
    This pull request builds on PR #264 (only the last commit is valid)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fhueske/incubator-flink quotedStringParsing

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-flink/pull/265.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #265
    
----
commit be532817e00fa03050530e5995a3675740eb070d
Author: Fabian Hueske <fh...@apache.org>
Date:   2014-10-20T13:18:20Z

    [FLINK-1168] Added support for multi-char delimiters.
    This commit includes parts of Cbro's pull request and subsumes PR #247
    
    This closes #247

commit 95267269c694c16ee89191dc28c386f3165be432
Author: Fabian Hueske <fh...@apache.org>
Date:   2014-12-12T13:04:17Z

    [FLINK-1318] Simplified quoted string parsing, made it optional, and use a configurable quote character

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---