You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Eli Collins (Created) (JIRA)" <ji...@apache.org> on 2011/11/24 01:01:07 UTC

[jira] [Created] (HADOOP-7855) Improve DiskChecker javadocs

Improve DiskChecker javadocs
----------------------------

                 Key: HADOOP-7855
                 URL: https://issues.apache.org/jira/browse/HADOOP-7855
             Project: Hadoop Common
          Issue Type: Bug
          Components: util
            Reporter: Eli Collins
             Fix For: 0.24.0


The javadocs for DiskChecker#checkDir(File dir) trail off, look like they weren't completed, should be. 

While checkDir(File) uses java File to check if a dir actually is writable, the version of checkDir that takes an FsPermission uses FsAction#implies which doesn't actually check if a dir is writable (eg it passes on a read-only file system). So switching from one version to the other can cause unexpected bugs. Let's call this out explicitly in the javadocs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (HADOOP-7855) Improve DiskChecker javadocs

Posted by "Harsh J (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harsh J resolved HADOOP-7855.
-----------------------------

       Resolution: Duplicate
    Fix Version/s:     (was: 0.24.0)

Dupe of HADOOP-7856 (Accidental dual-submit).
                
> Improve DiskChecker javadocs
> ----------------------------
>
>                 Key: HADOOP-7855
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7855
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: util
>            Reporter: Eli Collins
>              Labels: noob
>
> The javadocs for DiskChecker#checkDir(File dir) trail off, look like they weren't completed, should be. 
> While checkDir(File) uses java File to check if a dir actually is writable, the version of checkDir that takes an FsPermission uses FsAction#implies which doesn't actually check if a dir is writable (eg it passes on a read-only file system). So switching from one version to the other can cause unexpected bugs. Let's call this out explicitly in the javadocs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira