[GitHub] [ignite] nizhikov commented on a change in pull request #9432: IGNITE-13631 Improve data storage metrics descriptions

[GitBox <gi...@apache.org>]

nizhikov commented on a change in pull request #9432:
URL: https://github.com/apache/ignite/pull/9432#discussion_r714992503



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/DataStorageMetricsImpl.java
##########
@@ -187,25 +187,28 @@ public DataStorageMetricsImpl(
         MetricRegistry mreg = mmgr.registry(DATASTORAGE_METRIC_PREFIX);
 
         walLoggingRate = mreg.hitRateMetric("WalLoggingRate",
-            "Average number of WAL records per second written during the last time interval.",
+            "Average number of WAL records written per second. " +
+                "The rate is calculated over the configured time interval.",
             rateTimeInterval,
             subInts);
 
         walWritingRate = mreg.hitRateMetric(
             "WalWritingRate",
-            "Average number of bytes per second written during the last time interval.",
+            "Average number of bytes written to WAL per second. " +
+                "The rate is calculated over the configured time interval.",
             rateTimeInterval,
             subInts);
 
         walFsyncTimeDuration = mreg.hitRateMetric(
-            "WalFsyncTimeDuration",
-            "Total duration of fsync",
+            "WalFsyncDuration",
+            "Total time operations spent in the fsync phase writing WAL records to the disk " +
+                "since the start of the node in milliseconds.",
             rateTimeInterval,
             subInts);
 
         walFsyncTimeNum = mreg.hitRateMetric(
-            "WalFsyncTimeNum",
-            "Total count of fsync",
+            "WalFsyncNum",

Review comment:
       Do we really need to change metric name?
   Actually metric name is kind of public API and we don't want to change it without strong reason.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org