[Bug 7673] New: check_ratware_envelope_from only checks SRS uppercase

[bu...@bugzilla.spamassassin.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7673

            Bug ID: 7673
           Summary: check_ratware_envelope_from only checks SRS uppercase
           Product: Spamassassin
           Version: SVN Trunk (Latest Devel Version)
          Hardware: PC
                OS: Windows NT
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Plugins
          Assignee: dev@spamassassin.apache.org
          Reporter: wesley@syn.io
  Target Milestone: Undefined

It looks like check_ratware_envelope_from in
http://svn.apache.org/viewvc/spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/HeaderEval.pm?view=markup
only checks /^SRS\d=/ when SRS is uppercase on line 1075 (for SVN revision
1845749). However, during my testing it looks like it often comes in lowercase
(srs0=) on my system.

Would it be possible to do this check case-insensitive?

Or is it supposed to always be uppercase according to standards? Then it might
be a bug somewhere else.. PostSRSd or Postfix maybe..? But I wasn't able to
find out where it gets converted to lowercase.. And we can't change all
external mailservers to force them to send SRS in uppercase?

So even then, it might be great if SpamAssassin would work around it since
other servers might be configured like mine?

Making the check case-insensitive did fix the issue for myself...

PS: What should I do in the meantime to get this fixed without having to touch
the code? A lot of mails are being flagged as spam incorrectly because of this.
Should I just disable the RATWARE_EFROM rule for now?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7673] check_ratware_envelope_from only checks SRS uppercase

[bu...@bugzilla.spamassassin.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7673

Wesley Stessens <we...@syn.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wesley@syn.io
                 OS|Windows NT                  |Linux

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7673] check_ratware_envelope_from only checks SRS uppercase

[bu...@bugzilla.spamassassin.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7673

Giovanni Bechis <gi...@paclan.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |giovanni@paclan.it
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #2 from Giovanni Bechis <gi...@paclan.it> ---
Good catch, fixed in r1849747.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7673] check_ratware_envelope_from only checks SRS uppercase

[bu...@bugzilla.spamassassin.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7673

RW <rw...@googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rwmaillists@googlemail.com

--- Comment #1 from RW <rw...@googlemail.com> ---
I'd just disable it. I've never seen it hit anything, and according to rule QA
it only hits about 1 in 50k spams, and hits more ham than spam.

If you want to try working around your problem you could define:


header __RATWARE_EFROM eval:check_ratware_envelope_from()

meta RATWARE_EFROM     __RATWARE_EFROM && !__EFROM_SRS

You will have to define __EFROM_SRS based on whatever envelope-from header is
available at scan time.

-- 
You are receiving this mail because:
You are the assignee for the bug.