You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2020/11/10 17:10:33 UTC
[GitHub] [logging-log4j-kotlin] roedll opened a new pull request #13: Ensure OSGi compatibility
roedll opened a new pull request #13:
URL: https://github.com/apache/logging-log4j-kotlin/pull/13
We are using the Log4J Kotlin API in an OSGi environment. One pitfall is the missing manifest headers that would enable the direct usage as OSGi bundle. We are currently working with a workaraound, that wraps (repackages) the jar as a bundle and adds those headers on the fly.
But "native" support would be way better ;-)
To use a jar as an OSGi bundle, the manifest needs to have additional headers.
These headers describe the bundle and provide additional information.
This MR adds those headers and some additional Maven configuration to automaitcally add those headers into the resulting MANIFEST.MF file.
Some resources that deal with OSGi, manifest headers and "bundelization":
* https://docs.osgi.org/specification/osgi.core/7.0.0/framework.module.html
* https://www.osgi.org/bundle-headers-reference/
* https://vaadin.com/docs/flow/advanced/tutorial-making-components-osgi-compatible.html
* https://bnd.bndtools.org/chapters/390-wrapping.html
* https://livebook.manning.com/book/osgi-in-depth/appendix-a/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j-kotlin] rocketraman commented on pull request #13: Ensure OSGi compatibility
Posted by GitBox <gi...@apache.org>.
rocketraman commented on pull request #13:
URL: https://github.com/apache/logging-log4j-kotlin/pull/13#issuecomment-725447578
@jvz This PR LGTM. Are there any hoops we need to jump through before merging?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j-kotlin] jvz commented on pull request #13: Ensure OSGi compatibility
Posted by GitBox <gi...@apache.org>.
jvz commented on pull request #13:
URL: https://github.com/apache/logging-log4j-kotlin/pull/13#issuecomment-725460166
Nah, go ahead. There might be some OSGi bugs in Log4j itself, but those
would be handled separately.
On Wed, Nov 11, 2020 at 08:16 Raman Gupta <no...@github.com> wrote:
> @jvz <https://github.com/jvz> This PR LGTM. Are there any hoops we need
> to jump through before merging?
>
> —
> You are receiving this because you were mentioned.
>
>
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/logging-log4j-kotlin/pull/13#issuecomment-725447578>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAGBF265BBP5XUQGVR5SFCTSPKMEFANCNFSM4TQ5U62A>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j-kotlin] roedll commented on pull request #13: Ensure OSGi compatibility
Posted by GitBox <gi...@apache.org>.
roedll commented on pull request #13:
URL: https://github.com/apache/logging-log4j-kotlin/pull/13#issuecomment-724917908
No problem - Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j-kotlin] roedll edited a comment on pull request #13: Ensure OSGi compatibility
Posted by GitBox <gi...@apache.org>.
roedll edited a comment on pull request #13:
URL: https://github.com/apache/logging-log4j-kotlin/pull/13#issuecomment-725226670
The standard path for bnd metadata seems to be the "\<module>/bnd.bnd" (like defined here https://bnd.bndtools.org/md/805-instructions.html in section "Headers")
I've now synchronized it with the "artifactId"...
It's now "\<module>/bnd/\<artifactId>.bnd"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j-kotlin] rocketraman merged pull request #13: Ensure OSGi compatibility
Posted by GitBox <gi...@apache.org>.
rocketraman merged pull request #13:
URL: https://github.com/apache/logging-log4j-kotlin/pull/13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j-kotlin] rocketraman commented on pull request #13: Ensure OSGi compatibility
Posted by GitBox <gi...@apache.org>.
rocketraman commented on pull request #13:
URL: https://github.com/apache/logging-log4j-kotlin/pull/13#issuecomment-724861595
Thanks for this. I'd like to see the `bnd` definition file in a subdirectory rather than at the root e.g. `bnd/log4j-kotlin-api.bnd`
```
<configuration>
<bndfile>bnd/log4j-kotlin-api.bnd</bndfile>
</configuration>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j-kotlin] roedll commented on pull request #13: Ensure OSGi compatibility
Posted by GitBox <gi...@apache.org>.
roedll commented on pull request #13:
URL: https://github.com/apache/logging-log4j-kotlin/pull/13#issuecomment-725226670
The standard path for bnd metadata seems to be the "<module>/bnd.bnd" (like defined here https://bnd.bndtools.org/md/805-instructions.html in section "Headers")
I've now synchronized it with the "artifactId"...
It's now "<module>/bnd/<artifactId>.bnd"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org