You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/12/29 18:49:54 UTC
[GitHub] [maven-surefire] andpab opened a new pull request, #590: [SUREFIRE-2138] Update Junit4/5 version in docs and ITs
andpab opened a new pull request, #590:
URL: https://github.com/apache/maven-surefire/pull/590
- Update JUnit versions referenced in configuration examples
to 4.13.2 and 5.9.1, the respective latest versions
- Add 4.13.1 and 4.13.2 to JUnitVersion and JUnit4VersionsIT
- Use 4.13.2 where 4.13 or 4.13.1 was used in ITs
- Use 5.9.1 in all ITs except if a specific version is needed
- Add the necessary requires for org.junit.jupiter.api to the
module-info.java where it was still missing
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean install` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean install`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] andpab commented on pull request #590: [SUREFIRE-2138] Update Junit4/5 version in docs and ITs
Posted by GitBox <gi...@apache.org>.
andpab commented on PR #590:
URL: https://github.com/apache/maven-surefire/pull/590#issuecomment-1371268106
That's great news. Looking forward to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski merged pull request #590: [SUREFIRE-2138] Update Junit4/5 version in docs and ITs
Posted by GitBox <gi...@apache.org>.
slawekjaranowski merged PR #590:
URL: https://github.com/apache/maven-surefire/pull/590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] andpab commented on pull request #590: [SUREFIRE-2138] Update Junit4/5 version in docs and ITs
Posted by GitBox <gi...@apache.org>.
andpab commented on PR #590:
URL: https://github.com/apache/maven-surefire/pull/590#issuecomment-1367590484
The IT failure on macOS with jdk17 seems to be unrelated. It's Surefire1179IT which is a TestNG test that should be entirely unaffected by my changes. Probably a flaky test of sorts. I'll try to trigger a new build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] andpab commented on pull request #590: [SUREFIRE-2138] Update Junit4/5 version in docs and ITs
Posted by GitBox <gi...@apache.org>.
andpab commented on PR #590:
URL: https://github.com/apache/maven-surefire/pull/590#issuecomment-1371188852
@slawekjaranowski Thanks for reviewing and merging. Is there anything else that needs to be triggered so that the website is updated or is it only updated when a new release is made?
Currently it still shows the old state: https://maven.apache.org/surefire/maven-surefire-plugin/examples/junit.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on pull request #590: [SUREFIRE-2138] Update Junit4/5 version in docs and ITs
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #590:
URL: https://github.com/apache/maven-surefire/pull/590#issuecomment-1371211261
@andpab site is updated during release with new version.
I'm looking into current changes, I think that new release will be appreciated.
So I will try to take care about it .... probably at the end of month. 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org