You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by zh...@gmail.com on 2010/03/20 01:50:55 UTC
Remove duplicate Bypass enum (issue668041)
Reviewers: shindig.remailer_gmail.com, johnfargo,
Description:
As part of the rewriter refactoring two Bypass enums exists, and for
each there is a static function which uses it.
This cause a problem since most classes used the old enum while
TrustedTemplateTagHandler used the new one.
To prevent confusion, the old enum is removed.
I scan the rest of the "old" classes and didn't find other similar
cases.
Please review this at http://codereview.appspot.com/668041/show
Affected files:
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/SanitizingGadgetRewriter.java
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/old/SanitizingGadgetRewriter.java
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/TemplateRewriter.java
java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/XmlTemplateLibrary.java
java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/tags/FlashTagHandler.java
java/gadgets/src/test/java/org/apache/shindig/gadgets/DefaultGadgetSpecFactoryTest.java
java/gadgets/src/test/java/org/apache/shindig/gadgets/render/old/SanitizingGadgetRewriterTest.java
java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/DefaultTemplateProcessorTest.java