[GitHub] [arrow-adbc] lidavidm commented on a diff in pull request #783: chore(c): Changed import to common/util

["lidavidm (via GitHub)" <gi...@apache.org>]

lidavidm commented on code in PR #783:
URL: https://github.com/apache/arrow-adbc/pull/783#discussion_r1228640949


##########
c/driver/common/CMakeLists.txt:
##########
@@ -17,8 +17,8 @@
 
 add_library(adbc_driver_common STATIC utils.c)
 set_target_properties(adbc_driver_common PROPERTIES POSITION_INDEPENDENT_CODE ON)
-include_directories(SYSTEM ${REPOSITORY_ROOT})
-include_directories(SYSTEM ${REPOSITORY_ROOT}/c/vendor)
+target_include_directories(adbc_driver_common SYSTEM

Review Comment:
   We don't want SYSTEM for this one; SYSTEM translates to `-isystem` or the compiler equivalent which basically means to not issue warnings for things in that header.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org