[PATCH] [RUBY] typo fixes

[Evan Phoenix <ev...@fallingsnow.net>]

This patch fixes a few typo-style bugs in the ruby bindings.
[[[

* subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c
 (ra_callbacks_get_wc_prop) properly support returning NULL
 (ra_callbacks_push_wc_prop) 5 elements, not 4. and typo, should have been
        value as the last arg, not name.

* subversion/bindings/swig/ruby/svn/delta.rb
 (change_dir_prop) typo, pass through the passed in dir_baton
 (close_edit) takes a baton as well.

* subversion/bindings/swig/ruby/svn/ra.rb
 (set_path) Ra, not Rs
 (delete_path) Ra, not Rs

]]]

--
When I do good, I feel good;  when I do bad, I feel bad,
and that is my religion.
    -- Abraham Lincoln (1809 - 1865)

Re: [PATCH] [RUBY] typo fixes

[Kouhei Sutou <ko...@cozmixng.org>]

Hi,

In <92...@mail.gmail.com>
  "[PATCH] [RUBY] typo fixes" on Wed, 12 Apr 2006 17:57:06 -0700,
  "Evan Phoenix" <ev...@fallingsnow.net> wrote:

> * subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c
>  (ra_callbacks_get_wc_prop) properly support returning NULL

I committed this in r19339.

> * subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c
>  (ra_callbacks_push_wc_prop) 5 elements, not 4. and typo, should have been
>         value as the last arg, not name.
> * subversion/bindings/swig/ruby/svn/delta.rb
>  (change_dir_prop) typo, pass through the passed in dir_baton
> * subversion/bindings/swig/ruby/svn/ra.rb
>  (set_path) Ra, not Rs
>  (delete_path) Ra, not Rs

I committed them in r19340.

> * subversion/bindings/swig/ruby/svn/delta.rb
>  (close_edit) takes a baton as well.

I can't understand why this is needed. Could you explain
this?


Thanks for your many patches.


Regards,
--
kou

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org