You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Padma Priya N <pa...@gmail.com> on 2016/12/06 09:44:50 UTC

Review Request 54413: AMBARI-19031 : UI Enhancements, import/export assets and smart version configuration

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54413/
-----------------------------------------------------------

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Pallav Kulshreshtha.


Bugs: AMBARI-19031
    https://issues.apache.org/jira/browse/AMBARI-19031


Repository: ambari


Description
-------

UX Enhancemenets 
 - Dashboard as a tab
 - Coordinator UI changes
 - Bundle smart name autofil
Features 
 - Version setting picked up from Oozie
 - Ability to import/export assets(actions)


Diffs
-----

  contrib/views/wfmanager/pom.xml d4aedf3 
  contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/AmbariIOUtil.java PRE-CREATION 
  contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/HDFSFileUtils.java 58c3980 
  contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java 0533f04 
  contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieUtils.java 170132f 
  contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/WorkflowFileInfo.java PRE-CREATION 
  contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/WorkflowFilesService.java PRE-CREATION 
  contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetRepo.java PRE-CREATION 
  contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetService.java PRE-CREATION 
  contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/model/ActionAsset.java PRE-CREATION 
  contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/model/BaseModel.java PRE-CREATION 
  contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowManagerService.java PRE-CREATION 
  contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowsManagerResource.java PRE-CREATION 
  contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowsRepo.java PRE-CREATION 
  contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/model/Workflow.java PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 2799db5 
  contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-coord-config.js 229b2cc 
  contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-version-settings.js PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 57fcdf8 
  contrib/views/wfmanager/src/main/resources/ui/app/components/coord-version-settings.js PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/components/date-with-expr.js dd9a9ae 
  contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js a3d64b0 
  contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js ed743f4 
  contrib/views/wfmanager/src/main/resources/ui/app/components/hdfs-browser.js 232df16 
  contrib/views/wfmanager/src/main/resources/ui/app/components/import-from-stream.js PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js 4fa2666 
  contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js e403dc4 
  contrib/views/wfmanager/src/main/resources/ui/app/components/job-row.js 297244a 
  contrib/views/wfmanager/src/main/resources/ui/app/components/name-value-config.js ae453a0 
  contrib/views/wfmanager/src/main/resources/ui/app/components/preview-dialog.js 31f9df8 
  contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js b41f743 
  contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js 420d3b0 
  contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-actions.js 7fc1c94 
  contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-icon.js PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/controllers/design/dashboardtab.js PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/controllers/design/jobtab.js PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/controllers/job.js 2c90be4 
  contrib/views/wfmanager/src/main/resources/ui/app/domain/bundle/bundle-xml-generator.js 957d1c0 
  contrib/views/wfmanager/src/main/resources/ui/app/domain/bundle/bundle-xml-importer.js aa96221 
  contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-generator.js a657706 
  contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-importer.js fca90b3 
  contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js 086916f 
  contrib/views/wfmanager/src/main/resources/ui/app/domain/mapping-utils.js 2962e71 
  contrib/views/wfmanager/src/main/resources/ui/app/domain/schema-versions.js 9562ae8 
  contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js 7415544 
  contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-xml-generator.js 7049fde 
  contrib/views/wfmanager/src/main/resources/ui/app/router.js 1fcd633 
  contrib/views/wfmanager/src/main/resources/ui/app/routes/dashboard.js 949d39a 
  contrib/views/wfmanager/src/main/resources/ui/app/routes/design.js 5ed2619 
  contrib/views/wfmanager/src/main/resources/ui/app/routes/design/dashboardtab.js PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/routes/design/jobtab.js PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/routes/index.js 0fbbaa2 
  contrib/views/wfmanager/src/main/resources/ui/app/routes/job.js d849609 
  contrib/views/wfmanager/src/main/resources/ui/app/services/dashboard-context.js PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/services/save-job.js PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 5d1b3a3 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs 27168a4 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-coord-config.hbs 86a49b9 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-job-details.hbs f6b491b 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-version-settings.hbs PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs a6edcec 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-job-details.hbs 350f873 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-version-settings.hbs PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs b775302 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs c8f0f0e 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hdfs-browser.hbs 1922020 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/import-from-stream.hbs PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-config.hbs ede8cb1 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-details.hbs 0a04d25 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-row.hbs fdecbd9 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/preview-dialog.hbs 943c917 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-create-new-bar.hbs 211f720 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-table.hbs 8b27496 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-actions.hbs 7c883af 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-icon.hbs PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-details.hbs 5b33c41 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/design.hbs cb0462c 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/design/dashboardtab.hbs PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/design/jobtab.hbs PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/job.hbs 0a6da66 
  contrib/views/wfmanager/src/main/resources/ui/app/utils/common-utils.js e575d20 
  contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js 2f7df82 
  contrib/views/wfmanager/src/main/resources/ui/bower.json 0d897f1 
  contrib/views/wfmanager/src/main/resources/ui/ember-cli-build.js 5f8b81c 
  contrib/views/wfmanager/src/main/resources/ui/package.json ab9426a 
  contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/bundle-version-settings-test.js PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/coord-version-settings-test.js PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/import-from-stream-test.js PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/workflow-icon-test.js PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/tests/unit/routes/design/dashboardtab-test.js PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/tests/unit/services/dashboard-context-test.js PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/tests/unit/services/save-job-test.js PRE-CREATION 

Diff: https://reviews.apache.org/r/54413/diff/


Testing
-------

Manual Testing


Thanks,

Padma Priya N