You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/01/22 23:42:59 UTC
Review Request 17210: Added 'hostname' flag to the master.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17210/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Brenden Matthews, and Jiang Yan Xu.
Bugs: MESOS-672
https://issues.apache.org/jira/browse/MESOS-672
Repository: mesos-git
Description
-------
This is part 1 for MESOS-672.
Note that this depends on the reviews for MESOS-903
Diffs
-----
include/mesos/mesos.proto 655f86757487ddbe551fdcf53eb793e773ecdd34
src/common/date_utils.hpp 69fa03a0b14155a660cc9814f4142e99cb9351df
src/common/date_utils.cpp 3af9b4d3ca74ac1778debc68f264b8c8f6b7de32
src/master/flags.hpp 16faf96e46980ef61fc5045f1f37c2cf43dbab9a
src/master/master.cpp 008033e24b329623a3bbe865699bf0b555c0606d
Diff: https://reviews.apache.org/r/17210/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 17210: Added 'hostname' flag to the master.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17210/#review32760
-----------------------------------------------------------
Ship it!
Expose 'hostname' through http.cpp?
- Jiang Yan Xu
On Jan. 22, 2014, 2:42 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17210/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2014, 2:42 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Brenden Matthews, and Jiang Yan Xu.
>
>
> Bugs: MESOS-672
> https://issues.apache.org/jira/browse/MESOS-672
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is part 1 for MESOS-672.
>
> Note that this depends on the reviews for MESOS-903
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 655f86757487ddbe551fdcf53eb793e773ecdd34
> src/common/date_utils.hpp 69fa03a0b14155a660cc9814f4142e99cb9351df
> src/common/date_utils.cpp 3af9b4d3ca74ac1778debc68f264b8c8f6b7de32
> src/master/flags.hpp 16faf96e46980ef61fc5045f1f37c2cf43dbab9a
> src/master/master.cpp 008033e24b329623a3bbe865699bf0b555c0606d
>
> Diff: https://reviews.apache.org/r/17210/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 17210: Added 'hostname' flag to the master.
Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17210/#review32761
-----------------------------------------------------------
Ship it!
Looks great! Thanks for taking this on.
- Brenden Matthews
On Jan. 22, 2014, 10:42 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17210/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2014, 10:42 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Brenden Matthews, and Jiang Yan Xu.
>
>
> Bugs: MESOS-672
> https://issues.apache.org/jira/browse/MESOS-672
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is part 1 for MESOS-672.
>
> Note that this depends on the reviews for MESOS-903
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 655f86757487ddbe551fdcf53eb793e773ecdd34
> src/common/date_utils.hpp 69fa03a0b14155a660cc9814f4142e99cb9351df
> src/common/date_utils.cpp 3af9b4d3ca74ac1778debc68f264b8c8f6b7de32
> src/master/flags.hpp 16faf96e46980ef61fc5045f1f37c2cf43dbab9a
> src/master/master.cpp 008033e24b329623a3bbe865699bf0b555c0606d
>
> Diff: https://reviews.apache.org/r/17210/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 17210: Added 'hostname' flag to the master.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17210/
-----------------------------------------------------------
(Updated Feb. 11, 2014, 7:12 a.m.)
Review request for mesos, Benjamin Hindman, Brenden Matthews, and Jiang Yan Xu.
Changes
-------
rebased. NNFR.
Bugs: MESOS-672
https://issues.apache.org/jira/browse/MESOS-672
Repository: mesos-git
Description
-------
This is part 1 for MESOS-672.
Note that this depends on the reviews for MESOS-903
Diffs (updated)
-----
include/mesos/mesos.proto 1503e73f0d299f8efb209e0b10966c9a7f8db5f8
src/common/date_utils.hpp 69fa03a0b14155a660cc9814f4142e99cb9351df
src/common/date_utils.cpp 3af9b4d3ca74ac1778debc68f264b8c8f6b7de32
src/master/flags.hpp 16faf96e46980ef61fc5045f1f37c2cf43dbab9a
src/master/http.cpp fb15483953a593bfec4e60884219dc8c4e8d565c
src/master/master.cpp 4d9a9d15b38e021adc04c34b2e86734567bb957e
Diff: https://reviews.apache.org/r/17210/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 17210: Added 'hostname' flag to the master.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17210/
-----------------------------------------------------------
(Updated Feb. 6, 2014, 9:45 p.m.)
Review request for mesos, Benjamin Hindman, Brenden Matthews, and Jiang Yan Xu.
Changes
-------
rebased. NNFR.
Bugs: MESOS-672
https://issues.apache.org/jira/browse/MESOS-672
Repository: mesos-git
Description
-------
This is part 1 for MESOS-672.
Note that this depends on the reviews for MESOS-903
Diffs (updated)
-----
include/mesos/mesos.proto 1503e73f0d299f8efb209e0b10966c9a7f8db5f8
src/common/date_utils.hpp 69fa03a0b14155a660cc9814f4142e99cb9351df
src/common/date_utils.cpp 3af9b4d3ca74ac1778debc68f264b8c8f6b7de32
src/master/flags.hpp 16faf96e46980ef61fc5045f1f37c2cf43dbab9a
src/master/http.cpp fb15483953a593bfec4e60884219dc8c4e8d565c
src/master/master.cpp 77872ece66601043ddeb280cceba5a7676e8a6be
Diff: https://reviews.apache.org/r/17210/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 17210: Added 'hostname' flag to the master.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17210/#review33277
-----------------------------------------------------------
Ship it!
Ship It!
- Niklas Nielsen
On Jan. 22, 2014, 2:42 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17210/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2014, 2:42 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Brenden Matthews, and Jiang Yan Xu.
>
>
> Bugs: MESOS-672
> https://issues.apache.org/jira/browse/MESOS-672
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is part 1 for MESOS-672.
>
> Note that this depends on the reviews for MESOS-903
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 1503e73f0d299f8efb209e0b10966c9a7f8db5f8
> src/common/date_utils.hpp 69fa03a0b14155a660cc9814f4142e99cb9351df
> src/common/date_utils.cpp 3af9b4d3ca74ac1778debc68f264b8c8f6b7de32
> src/master/flags.hpp 16faf96e46980ef61fc5045f1f37c2cf43dbab9a
> src/master/http.cpp fb15483953a593bfec4e60884219dc8c4e8d565c
> src/master/master.cpp 77872ece66601043ddeb280cceba5a7676e8a6be
>
> Diff: https://reviews.apache.org/r/17210/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 17210: Added 'hostname' flag to the master.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17210/#review32586
-----------------------------------------------------------
Ship it!
src/common/date_utils.cpp
<https://reviews.apache.org/r/17210/#comment61491>
What about making this readable?
- Benjamin Hindman
On Jan. 22, 2014, 10:42 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17210/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2014, 10:42 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Brenden Matthews, and Jiang Yan Xu.
>
>
> Bugs: MESOS-672
> https://issues.apache.org/jira/browse/MESOS-672
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is part 1 for MESOS-672.
>
> Note that this depends on the reviews for MESOS-903
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 655f86757487ddbe551fdcf53eb793e773ecdd34
> src/common/date_utils.hpp 69fa03a0b14155a660cc9814f4142e99cb9351df
> src/common/date_utils.cpp 3af9b4d3ca74ac1778debc68f264b8c8f6b7de32
> src/master/flags.hpp 16faf96e46980ef61fc5045f1f37c2cf43dbab9a
> src/master/master.cpp 008033e24b329623a3bbe865699bf0b555c0606d
>
> Diff: https://reviews.apache.org/r/17210/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>