You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/01 08:49:29 UTC
[GitHub] [doris] eldenmoon opened a new pull request, #10542: [Enhancement] support compile with jemalloc
eldenmoon opened a new pull request, #10542:
URL: https://github.com/apache/doris/pull/10542
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10542: [Enhancement] support compile with jemalloc
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10542:
URL: https://github.com/apache/doris/pull/10542#issuecomment-1179941045
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #10542: [Enhancement] support compile with jemalloc
Posted by GitBox <gi...@apache.org>.
yiguolei commented on code in PR #10542:
URL: https://github.com/apache/doris/pull/10542#discussion_r912585477
##########
be/CMakeLists.txt:
##########
@@ -487,6 +487,8 @@ elseif ("${CMAKE_BUILD_TYPE}" STREQUAL "RELEASE")
SET(CMAKE_CXX_FLAGS ${CXX_FLAGS_RELEASE})
elseif ("${CMAKE_BUILD_TYPE}" STREQUAL "ASAN")
SET(CMAKE_CXX_FLAGS "${CXX_FLAGS_ASAN}")
+elseif ("${CMAKE_BUILD_TYPE}" STREQUAL "JEMALLOC")
Review Comment:
Use a separate flags to indicate using jemalloc or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #10542: [Enhancement] support compile with jemalloc
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #10542:
URL: https://github.com/apache/doris/pull/10542
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10542: [Enhancement] support compile with jemalloc
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10542:
URL: https://github.com/apache/doris/pull/10542#issuecomment-1172816887
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #10542: [Enhancement] support compile with jemalloc
Posted by GitBox <gi...@apache.org>.
yiguolei commented on code in PR #10542:
URL: https://github.com/apache/doris/pull/10542#discussion_r912588830
##########
be/src/http/action/pprof_actions.cpp:
##########
@@ -60,7 +60,8 @@ class HeapAction : public HttpHandler {
void HeapAction::handle(HttpRequest* req) {
std::lock_guard<std::mutex> lock(kPprofActionMutex);
-#if defined(ADDRESS_SANITIZER) || defined(LEAK_SANITIZER) || defined(THREAD_SANITIZER)
+#if defined(ADDRESS_SANITIZER) || defined(LEAK_SANITIZER) || defined(THREAD_SANITIZER) || \
+ defined(USE_JEMALLOC)
(void)kPprofDefaultSampleSecs; // Avoid unused variable warning.
std::string str = "Heap profiling is not available with address sanitizer builds.";
Review Comment:
Should modify the error message, add jemalloc to hint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] eldenmoon commented on a diff in pull request #10542: [Enhancement] support compile with jemalloc
Posted by GitBox <gi...@apache.org>.
eldenmoon commented on code in PR #10542:
URL: https://github.com/apache/doris/pull/10542#discussion_r912585796
##########
be/CMakeLists.txt:
##########
@@ -487,6 +487,8 @@ elseif ("${CMAKE_BUILD_TYPE}" STREQUAL "RELEASE")
SET(CMAKE_CXX_FLAGS ${CXX_FLAGS_RELEASE})
elseif ("${CMAKE_BUILD_TYPE}" STREQUAL "ASAN")
SET(CMAKE_CXX_FLAGS "${CXX_FLAGS_ASAN}")
+elseif ("${CMAKE_BUILD_TYPE}" STREQUAL "JEMALLOC")
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on pull request #10542: [Enhancement] support compile with jemalloc
Posted by GitBox <gi...@apache.org>.
yiguolei commented on PR #10542:
URL: https://github.com/apache/doris/pull/10542#issuecomment-1172139873
Great！！！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #10542: [Enhancement] support compile with jemalloc
Posted by GitBox <gi...@apache.org>.
yiguolei commented on code in PR #10542:
URL: https://github.com/apache/doris/pull/10542#discussion_r912589005
##########
be/src/http/action/pprof_actions.cpp:
##########
@@ -110,7 +111,8 @@ class GrowthAction : public HttpHandler {
};
void GrowthAction::handle(HttpRequest* req) {
-#if defined(ADDRESS_SANITIZER) || defined(LEAK_SANITIZER) || defined(THREAD_SANITIZER)
+#if defined(ADDRESS_SANITIZER) || defined(LEAK_SANITIZER) || defined(THREAD_SANITIZER) || \
+ defined(USE_JEMALLOC)
std::string str = "Growth profiling is not available with address sanitizer builds.";
Review Comment:
Here, add jemalloc to hint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10542: [Enhancement] support compile with jemalloc
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10542:
URL: https://github.com/apache/doris/pull/10542#issuecomment-1172816893
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #10542: [Enhancement] support compile with jemalloc
Posted by GitBox <gi...@apache.org>.
yiguolei commented on code in PR #10542:
URL: https://github.com/apache/doris/pull/10542#discussion_r912589080
##########
be/src/http/action/pprof_actions.cpp:
##########
@@ -132,7 +134,8 @@ class ProfileAction : public HttpHandler {
};
void ProfileAction::handle(HttpRequest* req) {
-#if defined(ADDRESS_SANITIZER) || defined(LEAK_SANITIZER) || defined(THREAD_SANITIZER)
+#if defined(ADDRESS_SANITIZER) || defined(LEAK_SANITIZER) || defined(THREAD_SANITIZER) || \
+ defined(USE_JEMALLOC)
std::string str = "CPU profiling is not available with address sanitizer builds.";
Review Comment:
Here, add jemalloc to hint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #10542: [Enhancement] support compile with jemalloc
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #10542:
URL: https://github.com/apache/doris/pull/10542#issuecomment-1173110902
hi @eldenmoon , please rebase to pass the check.
And also, we need to modify the compile doc to explain how to use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org