You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "guohao-rosicky (via GitHub)" <gi...@apache.org> on 2023/09/21 13:11:23 UTC
[GitHub] [ozone] guohao-rosicky opened a new pull request, #5341: HDDS-9335. OMKeyDeleteRequest using the wrong bucket layout
guohao-rosicky opened a new pull request, #5341:
URL: https://github.com/apache/ozone/pull/5341
## What changes were proposed in this pull request?
OMKeyDeleteRequest using the wrong bucket layout
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9335
## How was this patch tested?
existing UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sumitagrawl commented on pull request #5341: HDDS-9335. OMKeyDeleteRequest using the wrong bucket layout
Posted by "sumitagrawl (via GitHub)" <gi...@apache.org>.
sumitagrawl commented on PR #5341:
URL: https://github.com/apache/ozone/pull/5341#issuecomment-1732940746
@guohao-rosicky Plz fix UT cases as impact of changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sodonnel commented on pull request #5341: HDDS-9335. OMKeyDeleteRequest using the wrong bucket layout
Posted by "sodonnel (via GitHub)" <gi...@apache.org>.
sodonnel commented on PR #5341:
URL: https://github.com/apache/ozone/pull/5341#issuecomment-1729974989
Looks correct to me, but I'll also let someone who knows more about OM comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9335. OMKeyDeleteRequest using the wrong bucket layout [ozone]
Posted by "guohao-rosicky (via GitHub)" <gi...@apache.org>.
guohao-rosicky commented on PR #5341:
URL: https://github.com/apache/ozone/pull/5341#issuecomment-1751631751
> @guohao-rosicky Plz fix UT cases as impact of changes
Thanks for the revew @sumitagrawl, PTAL.
All ci passed, see: https://github.com/guohao-rosicky/ozone/actions/runs/6438542195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] guohao-rosicky commented on pull request #5341: HDDS-9335. OMKeyDeleteRequest using the wrong bucket layout
Posted by "guohao-rosicky (via GitHub)" <gi...@apache.org>.
guohao-rosicky commented on PR #5341:
URL: https://github.com/apache/ozone/pull/5341#issuecomment-1731055861
> we can remove method with passing bucketLayout and merge both
Thanks @sodonnel @ivandika3 @hemantk-12 @sumitagrawl for the review, I think it's a good idea. I'll modify it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9335. OMKeyDeleteRequest using the wrong bucket layout [ozone]
Posted by "sumitagrawl (via GitHub)" <gi...@apache.org>.
sumitagrawl merged PR #5341:
URL: https://github.com/apache/ozone/pull/5341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ivandika3 commented on pull request #5341: HDDS-9335. OMKeyDeleteRequest using the wrong bucket layout
Posted by "ivandika3 (via GitHub)" <gi...@apache.org>.
ivandika3 commented on PR #5341:
URL: https://github.com/apache/ozone/pull/5341#issuecomment-1730704716
Thanks for the patch.
I noticed there are some inconsistencies in the usage of bucket layout in the request.
```java
OmKeyInfo omKeyInfo =
omMetadataManager.getKeyTable(bucketLayout).get(objectKey);
```
and
```java
omMetadataManager.getKeyTable(getBucketLayout()).addCacheEntry(
new CacheKey<>(
omMetadataManager.getOzoneKey(volumeName, bucketName, keyName)),
CacheValue.get(trxnLogIndex));
```
The first one uses the `bucketLayout` from the method argument, the second one uses `getBucketLayout`. Maybe we can remove the `validateAndUpdateCache` with the `bucketLayout` argument, and uses `getBucketLayout` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org