[GitHub] [incubator-pinot] haibow commented on issue #4722: Fix segmentMetadata for MutableSegment

[GitBox <gi...@apache.org>]

haibow commented on issue #4722: Fix segmentMetadata for MutableSegment
URL: https://github.com/apache/incubator-pinot/pull/4722#issuecomment-544080202
 
 
   > Why do you need the class to be the same? As long as you can cast it to `SegmentMetadataImpl` (a subclass of `SegmentMetadataImpl`), you should be able to call all its API.
   > 
   > We should not allow setters for SegmentMetadata.
   
   It seems ok casting to `SegmentMetadataImpl` where I'm using it - just looks weird SegmentMetadata being a MutableSegment class, and need to cast it wherever it's used to avoid potential issues.
   
   Is it required to have no setters for SegmentMetadata? Overriding the getter methods kind of shows there is such need for mutable segments.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org