[jira] [Commented] (NUTCH-2247) Protocol resolver

["Sebastian Nagel (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NUTCH-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936622#comment-15936622 ] 

Sebastian Nagel commented on NUTCH-2247:
----------------------------------------

Hi Markus,
interesting tool!
- although ant is able to compile it, path and package name should be the same:
{noformat}
Index: src/java/org/apache/nutch/util/resolve/protocols/ResolveProtocols.java
...
+package org.apache.nutch.util.resolve;
{noformat}
- could leave away the stub methods setup and cleanup
- {{sampleSize}} is only used as initial list capacity and not as effective limit. Also a linear search over a large list will be slow, should use a HashSet instead.
- without documentation a less experienced user can hardly guess the aim of the tool

> Protocol resolver
> -----------------
>
>                 Key: NUTCH-2247
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2247
>             Project: Nutch
>          Issue Type: New Feature
>    Affects Versions: 1.11
>            Reporter: Markus Jelsma
>            Assignee: Markus Jelsma
>             Fix For: 1.13
>
>         Attachments: NUTCH-2274.patch
>
>
> Protocol resolver program capable of emitting rules for the urlnormalizer-protocol to ingest.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)