You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@quickstep.apache.org by zuyu <gi...@git.apache.org> on 2017/05/21 22:11:13 UTC

[GitHub] incubator-quickstep pull request #252: Simplified ExtractCommonSubexpression...

GitHub user zuyu opened a pull request:

    https://github.com/apache/incubator-quickstep/pull/252

    Simplified ExtractCommonSubexpression rule as a BottomUp rule.

    This small PR simplified PR #237 by deriving from a `BottomUpRule`.
    
    Assigned to @jianqiao.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zuyu/incubator-quickstep refactor-common-subexpr-rule

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-quickstep/pull/252.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #252
    
----
commit 7c7d0195ee9644b7655ae9f2faf129acc58accb1
Author: Zuyu Zhang <zu...@apache.org>
Date:   2017-05-21T21:49:08Z

    Simplified ExtractCommonSubexpression rule as a BottomUp rule.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #252: Simplified ExtractCommonSubexpression rule a...

Posted by zuyu <gi...@git.apache.org>.

Github user zuyu commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/252
  
    Done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #252: Simplified ExtractCommonSubexpression rule a...

Posted by jianqiao <gi...@git.apache.org>.

Github user jianqiao commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/252
  
    LGTM. Can you rebase the commit w.r.t. the current master HEAD? Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep pull request #252: Simplified ExtractCommonSubexpression...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-quickstep/pull/252


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---