[jira] [Commented] (SOLR-5629) SolrIndexSearcher.name should include core name

["Erick Erickson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-5629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870771#comment-13870771 ] 

Erick Erickson commented on SOLR-5629:
--------------------------------------

Assigned to myself just so it doesn't get lost, this seems uncontroversial.

But _where_ is this supposed to go? It looks like SolrIndexSearcher, about line 196 in 4x...

> SolrIndexSearcher.name should include core name
> -----------------------------------------------
>
>                 Key: SOLR-5629
>                 URL: https://issues.apache.org/jira/browse/SOLR-5629
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Shikhar Bhushan
>            Assignee: Erick Erickson
>            Priority: Minor
>
> The name attribute on {{SolrIndexSearcher}} is used in log lines, but does not include the core name.
> So in a multi-core setup it is unnecessarily difficult to trace what core's searcher is being referred to, e.g. in log lines that provide info on searcher opens & closes.
> One-line patch that helps:
> Replace
> {noformat}
> this.name = "Searcher@" + Integer.toHexString(hashCode()) + (name!=null ? " "+name : "");
> {noformat}
> with
> {noformat}
> this.name = "Searcher@" + Integer.toHexString(hashCode()) + "[" + core.getName() + "]" + (name!=null ? " "+name : "");
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org