[GitHub] [solr] janhoy commented on a change in pull request #749: SOLR-16106 ClusterState and BaseHttpClusterStateProvider should not depend on ZkStateReader

[GitBox <gi...@apache.org>]

janhoy commented on a change in pull request #749:
URL: https://github.com/apache/solr/pull/749#discussion_r829247192



##########
File path: solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java
##########
@@ -51,6 +50,10 @@
   private Set<String> liveNodes;
   private Set<String> hostAllowList;
 
+  // Copy of constants from ZkStateReader. Keep in sync if changed
+  public static final String NODE_NAME_PROP = "node_name";

Review comment:
       I thought about the same. Some CloudConstants file that can be part of common, and be used even by ZkStateReader.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org