You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Subhrat Chaudhary via Review Board <no...@reviews.apache.org> on 2023/02/07 18:20:19 UTC

Review Request 74298: RANGER-4023: UserStoreEnricher is not enabled if only mask conditon has attribute based expression

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74298/
-----------------------------------------------------------

Review request for ranger, Ankita Sinha and Madhan Neethiraj.


Bugs: https://issues.apache.org/jira/browse/RANGER-4023
    https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-4023


Repository: ranger


Description
-------

When only the masking condition has an user/group attribute based expression, RangerUserStoreEnricher is not enabled in plugin end. As part of the fix, we are checking for expression in custom masking conditon.


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/util/ServiceDefUtil.java fe1cf9244 
  agents-common/src/test/java/org/apache/ranger/plugin/util/ServiceDefUtilTest.java 3cd42f44f 


Diff: https://reviews.apache.org/r/74298/diff/1/


Testing
-------

Valiidated userstore.json is getting created in plugin, when only the masking condition has user/group attribute based expression.
Validated existing test cases are passing.


Thanks,

Subhrat Chaudhary


Re: Review Request 74298: RANGER-4023: UserStoreEnricher is not enabled if only mask conditon has attribute based expression

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74298/#review225478
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Feb. 7, 2023, 6:20 p.m., Subhrat Chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74298/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2023, 6:20 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha and Madhan Neethiraj.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/RANGER-4023
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-4023
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> When only the masking condition has an user/group attribute based expression, RangerUserStoreEnricher is not enabled in plugin end. As part of the fix, we are checking for expression in custom masking conditon.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/ServiceDefUtil.java fe1cf9244 
>   agents-common/src/test/java/org/apache/ranger/plugin/util/ServiceDefUtilTest.java 3cd42f44f 
> 
> 
> Diff: https://reviews.apache.org/r/74298/diff/1/
> 
> 
> Testing
> -------
> 
> Valiidated userstore.json is getting created in plugin, when only the masking condition has user/group attribute based expression.
> Validated existing test cases are passing.
> 
> 
> Thanks,
> 
> Subhrat Chaudhary
> 
>