[GitHub] [yunikorn-k8shim] wilfred-s commented on a diff in pull request #530: [YUNIKORN-1571] cleanup old plugin deployment examples

["wilfred-s (via GitHub)" <gi...@apache.org>]

wilfred-s commented on code in PR #530:
URL: https://github.com/apache/yunikorn-k8shim/pull/530#discussion_r1106499829


##########
deployments/scheduler/plugin.yaml:
##########
@@ -96,8 +97,6 @@ spec:
               cpu: 4
               memory: 2Gi
           volumeMounts:
-            - mountPath: /etc/kubernetes
-              name: scheduler-config
             - mountPath: /etc/yunikorn
               name: quotamanager-config

Review Comment:
   With the new configuration v2 do we need these?
   I could not find any mounting beside the secrets for the admission controller in the current helm charts.
   
   @craigcondit 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org