[jira] [Closed] (OFBIZ-10696) ConcurrentModificationException in ShoppingCart.cleanUpShipGroups

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-10696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-10696.
-----------------------------------
       Resolution: Fixed
    Fix Version/s: 16.11.06
                   17.12.01

Thanks Danny,

Your patch is in 
 trunk r1848336 
 R17 r1848337
 R16 r1848338

Actually I should have fixed that with OFBIZ-1953 (though for a different reason) but forgot :/.

Also I'd like to ask for you help to test a change of my own. Could you please replace the content of the method by   
{code:java}
public void cleanUpShipGroups() {
        shipInfo.removeIf(x -> x.shipItemInfo.keySet()
                .iterator()
                .next()
                .getQuantity()
                .compareTo(BigDecimal.ZERO) == 0);
        shipInfo.removeIf(x -> x.shipItemInfo.size() == 0);
    }{code}
and see if you get the same result?

I was not able to test it (I trust your changes are OK), so it would be very nice of you, thanks.

> ConcurrentModificationException in ShoppingCart.cleanUpShipGroups
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-10696
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10696
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Trunk
>            Reporter: Danny Trunk
>            Assignee: Jacques Le Roux
>            Priority: Major
>             Fix For: 17.12.01, 16.11.06
>
>         Attachments: OFBIZ-10696.diff
>
>
> {code:java}
> java.util.ConcurrentModificationException: null
>         at java.util.LinkedList$ListItr.checkForComodification(LinkedList.java:966) ~[?:1.8.0_181]
>         at java.util.LinkedList$ListItr.next(LinkedList.java:888) ~[?:1.8.0_181]
>         at org.apache.ofbiz.order.shoppingcart.ShoppingCart.cleanUpShipGroups(ShoppingCart.java:2199) ~[ofbiz.jar:?]
> {code}
> There's a for-loop over shipInfo and a call to clear inside this loop which leads to a ConcurrentModificationException: https://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCart.java?view=markup#l2251



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)