You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/07/31 12:11:08 UTC

[GitHub] flink pull request #4426: [FLINK-7303] [build] Build elasticsearch5 by defau...

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/4426

    [FLINK-7303] [build] Build elasticsearch5 by default

    ## What is the purpose of the change
    
    Remove unnecessary include-elasticsearch5 profile since its activation condition (usage of jdk8) is always true.
    
    ## Verifying this change
    
    Run any mvn command in `flink` or `flink-connectors` and check that the reactor includes ES5.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (~~yes~~ /  no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ~~(yes~~ / no)
      - The serializers: (~~yes~~ / no / ~~don't know~~)
      - The runtime per-record code paths (performance sensitive): (~~yes~~ / no / ~~don't know~~)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (~~yes~~ / no / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (~~yes~~ / no)
      - If yes, how is the feature documented? (not applicable ~~/ docs / JavaDocs / not documented~~)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 7303

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4426.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4426
    
----
commit bf91de71f756aae428adc20e3479c40bd73babc7
Author: zentol <ch...@apache.org>
Date:   2017-07-31T10:16:05Z

    [FLINK-7303] [build] Build elasticsearch5 by default

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4426: [FLINK-7303] [build] Build elasticsearch5 by default

Posted by greghogan <gi...@git.apache.org>.

Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/4426
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #4426: [FLINK-7303] [build] Build elasticsearch5 by defau...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4426


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4426: [FLINK-7303] [build] Build elasticsearch5 by default

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4426
  
    merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4426: [FLINK-7303] [build] Build elasticsearch5 by default

Posted by tzulitai <gi...@git.apache.org>.

Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/4426
  
    LGTM, +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---