You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2019/12/27 14:11:30 UTC
[GitHub] [bookkeeper] coolbeevip opened a new pull request #2226:
ISSUE-2224: Config ServerConfiguration with setAllowLoopback(true) for Unit
Tests
coolbeevip opened a new pull request #2226: ISSUE-2224: Config ServerConfiguration with setAllowLoopback(true) for Unit Tests
URL: https://github.com/apache/bookkeeper/pull/2226
### Motivation
Unit test fails when build master branch
### Changes
Config ServerConfiguration with setAllowLoopback(true) in the class GarbageCollectorThreadTest
Master Issue: #2224
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on issue #2226: ISSUE-2224: Config
ServerConfiguration with setAllowLoopback(true) for Unit Tests
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2226: ISSUE-2224: Config ServerConfiguration with setAllowLoopback(true) for Unit Tests
URL: https://github.com/apache/bookkeeper/pull/2226#issuecomment-569425778
I have sent a pr #2228 with a fix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] coolbeevip commented on issue #2226: ISSUE-2224:
Config ServerConfiguration with setAllowLoopback(true) for Unit Tests
Posted by GitBox <gi...@apache.org>.
coolbeevip commented on issue #2226: ISSUE-2224: Config ServerConfiguration with setAllowLoopback(true) for Unit Tests
URL: https://github.com/apache/bookkeeper/pull/2226#issuecomment-569431094
> In order to reproduce the issue you have to build with -Dstream
Thank you, `mvn clean package -Dstream` has been successfully on my local machine
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] jiazhai merged pull request #2226: ISSUE-2224: Config
ServerConfiguration with setAllowLoopback(true) for Unit Tests
Posted by GitBox <gi...@apache.org>.
jiazhai merged pull request #2226: ISSUE-2224: Config ServerConfiguration with setAllowLoopback(true) for Unit Tests
URL: https://github.com/apache/bookkeeper/pull/2226
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] ArvinDevel commented on issue #2226: ISSUE-2224:
Config ServerConfiguration with setAllowLoopback(true) for Unit Tests
Posted by GitBox <gi...@apache.org>.
ArvinDevel commented on issue #2226: ISSUE-2224: Config ServerConfiguration with setAllowLoopback(true) for Unit Tests
URL: https://github.com/apache/bookkeeper/pull/2226#issuecomment-569409170
> > run bookkeeper-server tls tests
>
> OK，I will try it
I just used that command to trigger Jenkins rebuild task.
It seems that the continuous-integration still fails, but I don't know how to trigger it manually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] jiazhai commented on issue #2226: ISSUE-2224: Config
ServerConfiguration with setAllowLoopback(true) for Unit Tests
Posted by GitBox <gi...@apache.org>.
jiazhai commented on issue #2226: ISSUE-2224: Config ServerConfiguration with setAllowLoopback(true) for Unit Tests
URL: https://github.com/apache/bookkeeper/pull/2226#issuecomment-571045558
rebuild java11
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on issue #2226: ISSUE-2224: Config
ServerConfiguration with setAllowLoopback(true) for Unit Tests
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2226: ISSUE-2224: Config ServerConfiguration with setAllowLoopback(true) for Unit Tests
URL: https://github.com/apache/bookkeeper/pull/2226#issuecomment-570900143
I have rebased to current master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] coolbeevip commented on issue #2226: ISSUE-2224:
Config ServerConfiguration with setAllowLoopback(true) for Unit Tests
Posted by GitBox <gi...@apache.org>.
coolbeevip commented on issue #2226: ISSUE-2224: Config ServerConfiguration with setAllowLoopback(true) for Unit Tests
URL: https://github.com/apache/bookkeeper/pull/2226#issuecomment-569410714
> > > run bookkeeper-server tls tests
> >
> >
> > OK，I will try it
>
> I just used that command to trigger Jenkins rebuild task.
> It seems that the continuous-integration still fails, but I don't know how to trigger it manually.
😅
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on issue #2226: ISSUE-2224: Config
ServerConfiguration with setAllowLoopback(true) for Unit Tests
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2226: ISSUE-2224: Config ServerConfiguration with setAllowLoopback(true) for Unit Tests
URL: https://github.com/apache/bookkeeper/pull/2226#issuecomment-570900455
Jenkins H30 node has problems, I have filed
https://issues.apache.org/jira/browse/INFRA-19660
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on issue #2226: ISSUE-2224: Config
ServerConfiguration with setAllowLoopback(true) for Unit Tests
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2226: ISSUE-2224: Config ServerConfiguration with setAllowLoopback(true) for Unit Tests
URL: https://github.com/apache/bookkeeper/pull/2226#issuecomment-570891944
If Travis won't be ok please rebase to latest master, that has #2228
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] coolbeevip commented on issue #2226: ISSUE-2224:
Config ServerConfiguration with setAllowLoopback(true) for Unit Tests
Posted by GitBox <gi...@apache.org>.
coolbeevip commented on issue #2226: ISSUE-2224: Config ServerConfiguration with setAllowLoopback(true) for Unit Tests
URL: https://github.com/apache/bookkeeper/pull/2226#issuecomment-569383003
> run bookkeeper-server tls tests
OK，I will try it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] coolbeevip edited a comment on issue #2226:
ISSUE-2224: Config ServerConfiguration with setAllowLoopback(true) for Unit
Tests
Posted by GitBox <gi...@apache.org>.
coolbeevip edited a comment on issue #2226: ISSUE-2224: Config ServerConfiguration with setAllowLoopback(true) for Unit Tests
URL: https://github.com/apache/bookkeeper/pull/2226#issuecomment-569412228
I found that checking license fails using script check-binary-license. The reason for the failure is that the 3rd party jars list in the LICENSE file does not exist in the lib directory.
e.g.
LICENSE contains the following, but these jars do not exist in bookkeeper-all-4.11.0-SNAPSHOT-bin.tar.gz
```
------------------------------------------------------------------------------------
The following bundled 3rd party jars are distributed under the
Apache Software License, Version 2.
...
- lib/io.grpc-grpc-all-1.18.0.jar [45]
- lib/io.grpc-grpc-auth-1.18.0.jar [45]
- lib/io.grpc-grpc-context-1.18.0.jar [45]
- lib/io.grpc-grpc-core-1.18.0.jar [45]
- lib/io.grpc-grpc-netty-1.18.0.jar [45]
- lib/io.grpc-grpc-okhttp-1.18.0.jar [45]
- lib/io.grpc-grpc-protobuf-1.18.0.jar [45]
- lib/io.grpc-grpc-protobuf-lite-1.18.0.jar [45]
- lib/io.grpc-grpc-protobuf-nano-1.18.0.jar [45]
- lib/io.grpc-grpc-stub-1.18.0.jar [45]
- lib/io.grpc-grpc-testing-1.18.0.jar [45]
...
```
I compared bookkeeper-all-4.11.0-SNAPSHOT.tar.gz and bookkeeper-server-4.10.0.tar.gz. I found that some jars contained in a no longer exist in bookkeeper-all-4.11.0-SNAPSHOT.tar.gz
If these jars are no longer needed, you need to remove them from LICENSE-all.bin.txt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] ArvinDevel commented on issue #2226: ISSUE-2224:
Config ServerConfiguration with setAllowLoopback(true) for Unit Tests
Posted by GitBox <gi...@apache.org>.
ArvinDevel commented on issue #2226: ISSUE-2224: Config ServerConfiguration with setAllowLoopback(true) for Unit Tests
URL: https://github.com/apache/bookkeeper/pull/2226#issuecomment-569380839
run bookkeeper-server tls tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] coolbeevip commented on issue #2226: ISSUE-2224:
Config ServerConfiguration with setAllowLoopback(true) for Unit Tests
Posted by GitBox <gi...@apache.org>.
coolbeevip commented on issue #2226: ISSUE-2224: Config ServerConfiguration with setAllowLoopback(true) for Unit Tests
URL: https://github.com/apache/bookkeeper/pull/2226#issuecomment-569412228
I found that checking license fails using script check-binary-license. The reason for the failure is that the 3rd party jars list in the LICENSE file does not exist in the lib directory.
e.g.
LICENSE contains the following, but these jars do not exist in bookkeeper-all-4.11.0-SNAPSHOT-bin.tar.gz
```
------------------------------------------------------------------------------------
The following bundled 3rd party jars are distributed under the
Apache Software License, Version 2.
...
- lib/io.grpc-grpc-all-1.18.0.jar [45]
- lib/io.grpc-grpc-auth-1.18.0.jar [45]
- lib/io.grpc-grpc-context-1.18.0.jar [45]
- lib/io.grpc-grpc-core-1.18.0.jar [45]
- lib/io.grpc-grpc-netty-1.18.0.jar [45]
- lib/io.grpc-grpc-okhttp-1.18.0.jar [45]
- lib/io.grpc-grpc-protobuf-1.18.0.jar [45]
- lib/io.grpc-grpc-protobuf-lite-1.18.0.jar [45]
- lib/io.grpc-grpc-protobuf-nano-1.18.0.jar [45]
- lib/io.grpc-grpc-stub-1.18.0.jar [45]
- lib/io.grpc-grpc-testing-1.18.0.jar [45]
...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on issue #2226: ISSUE-2224: Config
ServerConfiguration with setAllowLoopback(true) for Unit Tests
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2226: ISSUE-2224: Config ServerConfiguration with setAllowLoopback(true) for Unit Tests
URL: https://github.com/apache/bookkeeper/pull/2226#issuecomment-569425759
In order to reproduce the issue you have to build with -Dstream
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on issue #2226: ISSUE-2224: Config
ServerConfiguration with setAllowLoopback(true) for Unit Tests
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2226: ISSUE-2224: Config ServerConfiguration with setAllowLoopback(true) for Unit Tests
URL: https://github.com/apache/bookkeeper/pull/2226#issuecomment-569410412
We have problems on travis.
I am investigating.
The problem is not in this patch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on issue #2226: ISSUE-2224: Config
ServerConfiguration with setAllowLoopback(true) for Unit Tests
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2226: ISSUE-2224: Config ServerConfiguration with setAllowLoopback(true) for Unit Tests
URL: https://github.com/apache/bookkeeper/pull/2226#issuecomment-570891783
I have restarted Travis job.
This patch should be good to go now.
Thank you @coolbeevip
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on issue #2226: ISSUE-2224: Config
ServerConfiguration with setAllowLoopback(true) for Unit Tests
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2226: ISSUE-2224: Config ServerConfiguration with setAllowLoopback(true) for Unit Tests
URL: https://github.com/apache/bookkeeper/pull/2226#issuecomment-570922412
rebuild java11
run bookkeeper-server client tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services