[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6618: feat: `array_contains`

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #6618:
URL: https://github.com/apache/arrow-datafusion/pull/6618#discussion_r1242735645


##########
datafusion/physical-expr/src/array_expressions.rs:
##########
@@ -1070,6 +1071,70 @@ pub fn array_ndims(args: &[ColumnarValue]) -> Result<ColumnarValue> {
     ]))))
 }
 
+macro_rules! contains {

Review Comment:
   I don't quite understand this comment -- are you saying that it would be better to use the `in_list` kernel  rather than flattening it?



##########
docs/source/user-guide/expressions.md:
##########
@@ -179,23 +179,24 @@ Unlike to some databases the math functions in Datafusion works the same way as
 
 ## Array Expressions

Review Comment:
   ❤️ 



##########
docs/source/user-guide/sql/scalar_functions.md:
##########
@@ -1424,6 +1425,21 @@ array_concat(array[, ..., array_n])
   Can be a constant, column, or function, and any combination of array operators.
 - **array_n**: Subsequent array column or literal array to concatenate.
 
+### `array_contains`
+
+Returns true, if each element of the second array appearing in the first array, otherwise false.

Review Comment:
   ```suggestion
   Returns true, if each element of the second array appears in the first array, otherwise false.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org