You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jojy Varghese <jo...@mesosphere.io> on 2015/11/03 20:42:06 UTC
Review Request 39914: Added enable-ssl and enable-libevent to
reviewbot builds
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39914/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Cody Maloney.
Repository: mesos
Description
-------
SSL based tests are not currently verified on reviewbot. This change should enable those tests to be run.
Diffs
-----
support/verify_reviews.py 0d322a19af719aba8846fbc705bf8ec7647304a3
Diff: https://reviews.apache.org/r/39914/diff/
Testing
-------
Thanks,
Jojy Varghese
Re: Review Request 39914: Added enable-ssl and enable-libevent to
reviewbot builds
Posted by Jojy Varghese <jo...@mesosphere.io>.
> On Nov. 3, 2015, 8:10 p.m., Vinod Kone wrote:
> > would this only test libevent and skip libev? if yes, we can't do this.
Would it help to add libev also? I was trying to make this look like the jenkins mesos builds. Console logs there show :
``` echo CMD ./bootstrap '&&' ./configure --verbose --enable-libevent --enable-ssl && ...```
- Jojy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39914/#review104969
-----------------------------------------------------------
On Nov. 3, 2015, 7:42 p.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39914/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2015, 7:42 p.m.)
>
>
> Review request for mesos, Ben Mahler and Cody Maloney.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> SSL based tests are not currently verified on reviewbot. This change should enable those tests to be run.
>
>
> Diffs
> -----
>
> support/verify_reviews.py 0d322a19af719aba8846fbc705bf8ec7647304a3
>
> Diff: https://reviews.apache.org/r/39914/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 39914: Added enable-ssl and enable-libevent to
reviewbot builds
Posted by Jojy Varghese <jo...@mesosphere.io>.
> On Nov. 3, 2015, 8:10 p.m., Vinod Kone wrote:
> > would this only test libevent and skip libev? if yes, we can't do this.
>
> Jojy Varghese wrote:
> Would it help to add libev also? I was trying to make this look like the jenkins mesos builds. Console logs there show :
> ``` echo CMD ./bootstrap '&&' ./configure --verbose --enable-libevent --enable-ssl && ...```
>
> Vinod Kone wrote:
> the jenkins "mesos" build is a parameterized build, where one of the parameters is the configuration options. the config options we test are
> "--enable-libevent --enable-ssl" and "" (empty string which tests libev).
>
> unfortunately, the review bot doesn't support these parameters yet. review bot doesn't even run inside docker like the "mesos" build. so it just tests one platform (ubuntu) and the default parameters. it would be great if we can fix the review bot to do the same things as "mesos". feel free to create a ticket. i'll be happy to shepherd.
Just created https://issues.apache.org/jira/browse/MESOS-3825. Since there is only 1 platform, do we need to parameterize ? Can we just assume a fixed configuration ? Or add the required packages to the machine/VM and always use --enable-ssl and --enable-libevent ?
- Jojy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39914/#review104969
-----------------------------------------------------------
On Nov. 3, 2015, 7:42 p.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39914/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2015, 7:42 p.m.)
>
>
> Review request for mesos, Ben Mahler and Cody Maloney.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> SSL based tests are not currently verified on reviewbot. This change should enable those tests to be run.
>
>
> Diffs
> -----
>
> support/verify_reviews.py 0d322a19af719aba8846fbc705bf8ec7647304a3
>
> Diff: https://reviews.apache.org/r/39914/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 39914: Added enable-ssl and enable-libevent to
reviewbot builds
Posted by Vinod Kone <vi...@gmail.com>.
> On Nov. 3, 2015, 8:10 p.m., Vinod Kone wrote:
> > would this only test libevent and skip libev? if yes, we can't do this.
>
> Jojy Varghese wrote:
> Would it help to add libev also? I was trying to make this look like the jenkins mesos builds. Console logs there show :
> ``` echo CMD ./bootstrap '&&' ./configure --verbose --enable-libevent --enable-ssl && ...```
>
> Vinod Kone wrote:
> the jenkins "mesos" build is a parameterized build, where one of the parameters is the configuration options. the config options we test are
> "--enable-libevent --enable-ssl" and "" (empty string which tests libev).
>
> unfortunately, the review bot doesn't support these parameters yet. review bot doesn't even run inside docker like the "mesos" build. so it just tests one platform (ubuntu) and the default parameters. it would be great if we can fix the review bot to do the same things as "mesos". feel free to create a ticket. i'll be happy to shepherd.
>
> Jojy Varghese wrote:
> Just created https://issues.apache.org/jira/browse/MESOS-3825. Since there is only 1 platform, do we need to parameterize ? Can we just assume a fixed configuration ? Or add the required packages to the machine/VM and always use --enable-ssl and --enable-libevent ?
thanks for the ticket!
iirc, currently only one of "libev" or "libevent" can be enabled. so, if we change the bot to use libevent (because thats a dependency for ssl), then the bot won't be testing changes against libev.
regarding installing packages needed for libevent/ssl, we need to file a ticket with asf to get those packages installed on all the jenkins hosts, which is a PITA. that's the reason why "mesos" build moved to docker and why we need to move the bot to docker.
does that make sense?
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39914/#review104969
-----------------------------------------------------------
On Nov. 3, 2015, 7:42 p.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39914/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2015, 7:42 p.m.)
>
>
> Review request for mesos, Ben Mahler and Cody Maloney.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> SSL based tests are not currently verified on reviewbot. This change should enable those tests to be run.
>
>
> Diffs
> -----
>
> support/verify_reviews.py 0d322a19af719aba8846fbc705bf8ec7647304a3
>
> Diff: https://reviews.apache.org/r/39914/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 39914: Added enable-ssl and enable-libevent to
reviewbot builds
Posted by Vinod Kone <vi...@gmail.com>.
> On Nov. 3, 2015, 8:10 p.m., Vinod Kone wrote:
> > would this only test libevent and skip libev? if yes, we can't do this.
>
> Jojy Varghese wrote:
> Would it help to add libev also? I was trying to make this look like the jenkins mesos builds. Console logs there show :
> ``` echo CMD ./bootstrap '&&' ./configure --verbose --enable-libevent --enable-ssl && ...```
the jenkins "mesos" build is a parameterized build, where one of the parameters is the configuration options. the config options we test are
"--enable-libevent --enable-ssl" and "" (empty string which tests libev).
unfortunately, the review bot doesn't support these parameters yet. review bot doesn't even run inside docker like the "mesos" build. so it just tests one platform (ubuntu) and the default parameters. it would be great if we can fix the review bot to do the same things as "mesos". feel free to create a ticket. i'll be happy to shepherd.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39914/#review104969
-----------------------------------------------------------
On Nov. 3, 2015, 7:42 p.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39914/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2015, 7:42 p.m.)
>
>
> Review request for mesos, Ben Mahler and Cody Maloney.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> SSL based tests are not currently verified on reviewbot. This change should enable those tests to be run.
>
>
> Diffs
> -----
>
> support/verify_reviews.py 0d322a19af719aba8846fbc705bf8ec7647304a3
>
> Diff: https://reviews.apache.org/r/39914/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 39914: Added enable-ssl and enable-libevent to
reviewbot builds
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39914/#review104969
-----------------------------------------------------------
would this only test libevent and skip libev? if yes, we can't do this.
- Vinod Kone
On Nov. 3, 2015, 7:42 p.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39914/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2015, 7:42 p.m.)
>
>
> Review request for mesos, Ben Mahler and Cody Maloney.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> SSL based tests are not currently verified on reviewbot. This change should enable those tests to be run.
>
>
> Diffs
> -----
>
> support/verify_reviews.py 0d322a19af719aba8846fbc705bf8ec7647304a3
>
> Diff: https://reviews.apache.org/r/39914/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 39914: Changed verify_review to use
docker_build.sh.
Posted by Jojy Varghese <jo...@mesosphere.io>.
> On Nov. 4, 2015, 9:12 p.m., Vinod Kone wrote:
> > support/verify_reviews.py, line 122
> > <https://reviews.apache.org/r/39914/diff/2/?file=1115942#file1115942line122>
> >
> > have you verified this change locally?
> >
> > the docker_build.sh script expects certain environment variables to be set.
I ran the script locally by setting the OS, CONFIGURATION etc manually. I didnt know the workflow for setting these. How are these env variables set?
- Jojy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39914/#review105136
-----------------------------------------------------------
On Nov. 4, 2015, 8:47 p.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39914/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2015, 8:47 p.m.)
>
>
> Review request for mesos, Cody Maloney and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> SSL based tests are not currently verified on reviewbot. This change would make reviewbot environment to be same as mesos builds on jenkins.
>
>
> Diffs
> -----
>
> support/verify_reviews.py 0d322a19af719aba8846fbc705bf8ec7647304a3
>
> Diff: https://reviews.apache.org/r/39914/diff/
>
>
> Testing
> -------
>
> ran script locally
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 39914: Changed verify_review to use
docker_build.sh.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39914/#review105136
-----------------------------------------------------------
support/verify_reviews.py (line 122)
<https://reviews.apache.org/r/39914/#comment163531>
have you verified this change locally?
the docker_build.sh script expects certain environment variables to be set.
- Vinod Kone
On Nov. 4, 2015, 8:47 p.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39914/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2015, 8:47 p.m.)
>
>
> Review request for mesos, Cody Maloney and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> SSL based tests are not currently verified on reviewbot. This change would make reviewbot environment to be same as mesos builds on jenkins.
>
>
> Diffs
> -----
>
> support/verify_reviews.py 0d322a19af719aba8846fbc705bf8ec7647304a3
>
> Diff: https://reviews.apache.org/r/39914/diff/
>
>
> Testing
> -------
>
> ran script locally
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 39914: Changed verify_review to use
docker_build.sh.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39914/#review106127
-----------------------------------------------------------
support/verify_reviews.py (line 122)
<https://reviews.apache.org/r/39914/#comment164822>
there is no --enable-libev option. i will change this to --verbose when committing.
- Vinod Kone
On Nov. 11, 2015, 12:14 a.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39914/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2015, 12:14 a.m.)
>
>
> Review request for mesos, Cody Maloney and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> reviewbot builds dont use docker today. This change would make reviewbot environment to be same as mesos builds on jenkins which uses docker.
>
>
> Diffs
> -----
>
> support/verify_reviews.py 0d322a19af719aba8846fbc705bf8ec7647304a3
>
> Diff: https://reviews.apache.org/r/39914/diff/
>
>
> Testing
> -------
>
> ran script locally
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 39914: Changed verify_review to use
docker_build.sh.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39914/#review106125
-----------------------------------------------------------
Ship it!
- Vinod Kone
On Nov. 11, 2015, 12:14 a.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39914/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2015, 12:14 a.m.)
>
>
> Review request for mesos, Cody Maloney and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> reviewbot builds dont use docker today. This change would make reviewbot environment to be same as mesos builds on jenkins which uses docker.
>
>
> Diffs
> -----
>
> support/verify_reviews.py 0d322a19af719aba8846fbc705bf8ec7647304a3
>
> Diff: https://reviews.apache.org/r/39914/diff/
>
>
> Testing
> -------
>
> ran script locally
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 39914: Changed verify_review to use
docker_build.sh.
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39914/
-----------------------------------------------------------
(Updated Nov. 11, 2015, 12:14 a.m.)
Review request for mesos, Cody Maloney and Vinod Kone.
Changes
-------
updated description.
Repository: mesos
Description (updated)
-------
reviewbot builds dont use docker today. This change would make reviewbot environment to be same as mesos builds on jenkins which uses docker.
Diffs
-----
support/verify_reviews.py 0d322a19af719aba8846fbc705bf8ec7647304a3
Diff: https://reviews.apache.org/r/39914/diff/
Testing
-------
ran script locally
Thanks,
Jojy Varghese
Re: Review Request 39914: Changed verify_review to use
docker_build.sh.
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39914/
-----------------------------------------------------------
(Updated Nov. 10, 2015, 11:46 p.m.)
Review request for mesos, Cody Maloney and Vinod Kone.
Changes
-------
just keeping libev in default configuration.
Repository: mesos
Description
-------
SSL based tests are not currently verified on reviewbot. This change would make reviewbot environment to be same as mesos builds on jenkins.
Diffs (updated)
-----
support/verify_reviews.py 0d322a19af719aba8846fbc705bf8ec7647304a3
Diff: https://reviews.apache.org/r/39914/diff/
Testing
-------
ran script locally
Thanks,
Jojy Varghese
Re: Review Request 39914: Changed verify_review to use
docker_build.sh.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39914/#review105328
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39953, 39954, 39914]
All tests passed.
- Mesos ReviewBot
On Nov. 5, 2015, 8:12 p.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39914/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2015, 8:12 p.m.)
>
>
> Review request for mesos, Cody Maloney and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> SSL based tests are not currently verified on reviewbot. This change would make reviewbot environment to be same as mesos builds on jenkins.
>
>
> Diffs
> -----
>
> support/docker_build.sh cea5eaded739bc336e818a081fa308fb6b66fbef
> support/verify_reviews.py 0d322a19af719aba8846fbc705bf8ec7647304a3
>
> Diff: https://reviews.apache.org/r/39914/diff/
>
>
> Testing
> -------
>
> ran script locally
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 39914: Changed verify_review to use
docker_build.sh.
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39914/
-----------------------------------------------------------
(Updated Nov. 5, 2015, 8:12 p.m.)
Review request for mesos, Cody Maloney and Vinod Kone.
Changes
-------
replaced libevent with libev as default configuration.
Repository: mesos
Description
-------
SSL based tests are not currently verified on reviewbot. This change would make reviewbot environment to be same as mesos builds on jenkins.
Diffs (updated)
-----
support/docker_build.sh cea5eaded739bc336e818a081fa308fb6b66fbef
support/verify_reviews.py 0d322a19af719aba8846fbc705bf8ec7647304a3
Diff: https://reviews.apache.org/r/39914/diff/
Testing
-------
ran script locally
Thanks,
Jojy Varghese
Re: Review Request 39914: Changed verify_review to use
docker_build.sh.
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39914/
-----------------------------------------------------------
(Updated Nov. 5, 2015, 7:44 p.m.)
Review request for mesos, Cody Maloney and Vinod Kone.
Changes
-------
setting build env in the script.
Repository: mesos
Description
-------
SSL based tests are not currently verified on reviewbot. This change would make reviewbot environment to be same as mesos builds on jenkins.
Diffs (updated)
-----
support/verify_reviews.py 0d322a19af719aba8846fbc705bf8ec7647304a3
Diff: https://reviews.apache.org/r/39914/diff/
Testing
-------
ran script locally
Thanks,
Jojy Varghese
Re: Review Request 39914: Changed verify_review to use
docker_build.sh.
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39914/
-----------------------------------------------------------
(Updated Nov. 4, 2015, 8:47 p.m.)
Review request for mesos, Cody Maloney and Vinod Kone.
Changes
-------
after discussion with vinod.
Summary (updated)
-----------------
Changed verify_review to use docker_build.sh.
Repository: mesos
Description (updated)
-------
SSL based tests are not currently verified on reviewbot. This change would make reviewbot environment to be same as mesos builds on jenkins.
Diffs (updated)
-----
support/verify_reviews.py 0d322a19af719aba8846fbc705bf8ec7647304a3
Diff: https://reviews.apache.org/r/39914/diff/
Testing (updated)
-------
ran script locally
Thanks,
Jojy Varghese
Re: Review Request 39914: Added enable-ssl and enable-libevent to
reviewbot builds
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39914/#review104989
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39914]
All tests passed.
- Mesos ReviewBot
On Nov. 3, 2015, 7:42 p.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39914/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2015, 7:42 p.m.)
>
>
> Review request for mesos, Ben Mahler and Cody Maloney.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> SSL based tests are not currently verified on reviewbot. This change should enable those tests to be run.
>
>
> Diffs
> -----
>
> support/verify_reviews.py 0d322a19af719aba8846fbc705bf8ec7647304a3
>
> Diff: https://reviews.apache.org/r/39914/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 39914: Added enable-ssl and enable-libevent to
reviewbot builds
Posted by Jojy Varghese <jo...@mesosphere.io>.
> On Nov. 3, 2015, 7:46 p.m., Joseph Wu wrote:
> > Are openssl and libevent present on the reviewbot machine?
> > (And does reviewbot use the modified version of `verify_reviews.py` when checking this one?)
Not sure. I would think that the installation of dependencies exists outside the scoep of this file. Maybe dockerfile?
- Jojy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39914/#review104960
-----------------------------------------------------------
On Nov. 3, 2015, 7:42 p.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39914/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2015, 7:42 p.m.)
>
>
> Review request for mesos, Ben Mahler and Cody Maloney.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> SSL based tests are not currently verified on reviewbot. This change should enable those tests to be run.
>
>
> Diffs
> -----
>
> support/verify_reviews.py 0d322a19af719aba8846fbc705bf8ec7647304a3
>
> Diff: https://reviews.apache.org/r/39914/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 39914: Added enable-ssl and enable-libevent to
reviewbot builds
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39914/#review104960
-----------------------------------------------------------
Are openssl and libevent present on the reviewbot machine?
(And does reviewbot use the modified version of `verify_reviews.py` when checking this one?)
- Joseph Wu
On Nov. 3, 2015, 11:42 a.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39914/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2015, 11:42 a.m.)
>
>
> Review request for mesos, Ben Mahler and Cody Maloney.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> SSL based tests are not currently verified on reviewbot. This change should enable those tests to be run.
>
>
> Diffs
> -----
>
> support/verify_reviews.py 0d322a19af719aba8846fbc705bf8ec7647304a3
>
> Diff: https://reviews.apache.org/r/39914/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jojy Varghese
>
>