You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2019/05/03 11:27:05 UTC
Review Request 70589: Logged when `/__processes__` returns.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70589/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Till Toenshoff.
Repository: mesos
Description
-------
Adds a log entry when a response with generated by `/__processes__`
is about to be returned to the client.
Diffs
-----
3rdparty/libprocess/src/process.cpp 124836472313721a5dbfe4b1ca55f0da3cecd66b
Diff: https://reviews.apache.org/r/70589/diff/1/
Testing
-------
built & run on Mac OS 10.13.6
```
I0503 13:13:00.885133 59219968 process.cpp:3599] Handling HTTP event for process '__processes__' with path: '/__processes__'
I0503 13:13:00.886037 59219968 process.cpp:3412] HTTP GET for /__processes__ from 192.168.178.47:59548: '200 OK' after 1.06214ms
```
Thanks,
Alexander Rukletsov
Re: Review Request 70589: Logged when `/__processes__` returns.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70589/#review215046
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70589]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 3, 2019, 11:27 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70589/
> -----------------------------------------------------------
>
> (Updated May 3, 2019, 11:27 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds a log entry when a response with generated by `/__processes__`
> is about to be returned to the client.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 124836472313721a5dbfe4b1ca55f0da3cecd66b
>
>
> Diff: https://reviews.apache.org/r/70589/diff/1/
>
>
> Testing
> -------
>
> built & run on Mac OS 10.13.6
>
> ```
> I0503 13:13:00.885133 59219968 process.cpp:3599] Handling HTTP event for process '__processes__' with path: '/__processes__'
> I0503 13:13:00.886037 59219968 process.cpp:3412] HTTP GET for /__processes__ from 192.168.178.47:59548: '200 OK' after 1.06214ms
> ```
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 70589: Logged when `/__processes__` returns.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70589/#review215486
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70589]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 23, 2019, 10:59 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70589/
> -----------------------------------------------------------
>
> (Updated May 23, 2019, 10:59 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
>
>
> Bugs: MESOS-9766
> https://issues.apache.org/jira/browse/MESOS-9766
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds a log entry when a response with generated by `/__processes__`
> is about to be returned to the client.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp a47b5709095665bbe6141b7531b956aeb911d04a
>
>
> Diff: https://reviews.apache.org/r/70589/diff/2/
>
>
> Testing
> -------
>
> built & run on Mac OS 10.13.6
>
> ```
> I0503 13:13:00.885133 59219968 process.cpp:3599] Handling HTTP event for process '__processes__' with path: '/__processes__'
> I0503 13:13:00.886037 59219968 process.cpp:3412] HTTP GET for /__processes__ from 192.168.178.47:59548: '200 OK' after 1.06214ms
> ```
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 70589: Logged when `/__processes__` returns.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70589/
-----------------------------------------------------------
(Updated May 23, 2019, 10:59 a.m.)
Review request for mesos, Benjamin Mahler and Till Toenshoff.
Bugs: MESOS-9766
https://issues.apache.org/jira/browse/MESOS-9766
Repository: mesos
Description
-------
Adds a log entry when a response with generated by `/__processes__`
is about to be returned to the client.
Diffs (updated)
-----
3rdparty/libprocess/src/process.cpp a47b5709095665bbe6141b7531b956aeb911d04a
Diff: https://reviews.apache.org/r/70589/diff/2/
Changes: https://reviews.apache.org/r/70589/diff/1-2/
Testing
-------
built & run on Mac OS 10.13.6
```
I0503 13:13:00.885133 59219968 process.cpp:3599] Handling HTTP event for process '__processes__' with path: '/__processes__'
I0503 13:13:00.886037 59219968 process.cpp:3412] HTTP GET for /__processes__ from 192.168.178.47:59548: '200 OK' after 1.06214ms
```
Thanks,
Alexander Rukletsov
Re: Review Request 70589: Logged when `/__processes__` returns.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70589/#review215189
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/src/process.cpp
Lines 3412 (patched)
<https://reviews.apache.org/r/70589/#comment301733>
Perhaps a TODO to generalize the response logging in libprocess?
- Benjamin Mahler
On May 9, 2019, 1:09 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70589/
> -----------------------------------------------------------
>
> (Updated May 9, 2019, 1:09 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
>
>
> Bugs: MESOS-9766
> https://issues.apache.org/jira/browse/MESOS-9766
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds a log entry when a response with generated by `/__processes__`
> is about to be returned to the client.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 124836472313721a5dbfe4b1ca55f0da3cecd66b
>
>
> Diff: https://reviews.apache.org/r/70589/diff/1/
>
>
> Testing
> -------
>
> built & run on Mac OS 10.13.6
>
> ```
> I0503 13:13:00.885133 59219968 process.cpp:3599] Handling HTTP event for process '__processes__' with path: '/__processes__'
> I0503 13:13:00.886037 59219968 process.cpp:3412] HTTP GET for /__processes__ from 192.168.178.47:59548: '200 OK' after 1.06214ms
> ```
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 70589: Logged when `/__processes__` returns.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70589/
-----------------------------------------------------------
(Updated May 9, 2019, 1:09 p.m.)
Review request for mesos, Benjamin Mahler and Till Toenshoff.
Bugs: MESOS-9766
https://issues.apache.org/jira/browse/MESOS-9766
Repository: mesos
Description
-------
Adds a log entry when a response with generated by `/__processes__`
is about to be returned to the client.
Diffs
-----
3rdparty/libprocess/src/process.cpp 124836472313721a5dbfe4b1ca55f0da3cecd66b
Diff: https://reviews.apache.org/r/70589/diff/1/
Testing
-------
built & run on Mac OS 10.13.6
```
I0503 13:13:00.885133 59219968 process.cpp:3599] Handling HTTP event for process '__processes__' with path: '/__processes__'
I0503 13:13:00.886037 59219968 process.cpp:3412] HTTP GET for /__processes__ from 192.168.178.47:59548: '200 OK' after 1.06214ms
```
Thanks,
Alexander Rukletsov