You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/09 10:18:52 UTC
[GitHub] [flink] Myasuka commented on a change in pull request #14341: [FLINK-20496][state backends] RocksDB partitioned index/filters option.
Myasuka commented on a change in pull request #14341:
URL: https://github.com/apache/flink/pull/14341#discussion_r539051783
##########
File path: docs/_includes/generated/rocksdb_configuration.html
##########
@@ -46,7 +52,7 @@
</tr>
<tr>
<td><h5>state.backend.rocksdb.options-factory</h5></td>
- <td style="word-wrap: break-word;">"org.apache.flink.contrib.streaming.state.DefaultConfigurableOptionsFactory"</td>
+ <td style="word-wrap: break-word;">"org.apache.flink.contrib.streaming.state.DefaultConfigurableOptionsFactory"</td>RocksDBResourceContainerTest.java
Review comment:
The `RocksDBResourceContainerTest.java` is redundant.
##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBResourceContainer.java
##########
@@ -143,6 +144,11 @@ public ColumnFamilyOptions getColumnOptions() {
"We currently only support BlockBasedTableConfig When bounding total memory.");
blockBasedTableConfig = (BlockBasedTableConfig) tableFormatConfig;
}
+ if (rocksResources.isUsingPartitionedIndex()) {
Review comment:
From RocksDB's current implementation, partitioned index is only compatible with full bloom filter. From my point of view, we should check whether current filter is full instead of block based and set a default full bloom filter if current filter is not `null`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org