You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2022/11/06 13:06:10 UTC
[commons-net] 01/04: Better SubnetUtils.SubnetInfo.format(int[])
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-net.git
commit 8ee675ec635944438b95cd02257507e8d206a125
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun Nov 6 07:49:55 2022 -0500
Better SubnetUtils.SubnetInfo.format(int[])
---
src/main/java/org/apache/commons/net/util/SubnetUtils.java | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/src/main/java/org/apache/commons/net/util/SubnetUtils.java b/src/main/java/org/apache/commons/net/util/SubnetUtils.java
index 88bbe83c..5f84bf44 100644
--- a/src/main/java/org/apache/commons/net/util/SubnetUtils.java
+++ b/src/main/java/org/apache/commons/net/util/SubnetUtils.java
@@ -45,14 +45,15 @@ public class SubnetUtils {
* Convert a 4-element array into dotted decimal format
*/
private String format(final int[] octets) {
- final StringBuilder str = new StringBuilder();
- for (int i =0; i < octets.length; ++i){
- str.append(octets[i]);
- if (i != octets.length - 1) {
- str.append(".");
+ final int last = octets.length - 1;
+ final StringBuilder builder = new StringBuilder();
+ for (int i = 0;; i++) {
+ builder.append(octets[i]);
+ if (i == last) {
+ return builder.toString();
}
+ builder.append('.');
}
- return str.toString();
}
public String getAddress() {