(juneau) branch juneau-release-manager updated: Use a Shorts::ine method reference in EmailService and suppress the unused try-resource warning on RunLog and RunStateBroadcaster test subscriptions.

[ja...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

jamesbognar pushed a commit to branch juneau-release-manager
in repository https://gitbox.apache.org/repos/asf/juneau.git


The following commit(s) were added to refs/heads/juneau-release-manager by this push:
     new 36ca41ef07 Use a Shorts::ine method reference in EmailService and suppress the unused try-resource warning on RunLog and RunStateBroadcaster test subscriptions.
36ca41ef07 is described below

commit 36ca41ef07e44f246f6641c865c2d9fc28326c90
Author: James Bognar <ja...@apache.org>
AuthorDate: Tue Oct 6 17:50:13 2026 -0400

    Use a Shorts::ine method reference in EmailService and suppress the unused try-resource warning on RunLog and RunStateBroadcaster test subscriptions.
---
 src/main/java/org/apache/juneau/releng/email/EmailService.java      | 3 ++-
 src/test/java/org/apache/juneau/releng/log/RunLogTest.java          | 6 ++++++
 .../java/org/apache/juneau/releng/log/RunStateBroadcasterTest.java  | 6 ++++++
 3 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/src/main/java/org/apache/juneau/releng/email/EmailService.java b/src/main/java/org/apache/juneau/releng/email/EmailService.java
index 99870c0563..01ecb2e134 100644
--- a/src/main/java/org/apache/juneau/releng/email/EmailService.java
+++ b/src/main/java/org/apache/juneau/releng/email/EmailService.java
@@ -27,6 +27,7 @@ import java.util.Arrays;
 import java.util.List;
 import java.util.Map;
 import java.util.stream.Collectors;
+import org.apache.juneau.commons.utils.Shorts;
 import org.apache.juneau.releng.engine.RunState;
 import org.apache.juneau.releng.util.ProcessRunner;
 
@@ -130,7 +131,7 @@ public class EmailService {
 	 * Joins the non-blank sections with a single blank line between each and a trailing newline.
 	 */
 	private static String paragraphs(String... sections) {
-		return Arrays.stream(sections).filter(s -> ine(s)).collect(Collectors.joining("\n\n")) + "\n";
+		return Arrays.stream(sections).filter(Shorts::ine).collect(Collectors.joining("\n\n")) + "\n";
 	}
 
 	/**
diff --git a/src/test/java/org/apache/juneau/releng/log/RunLogTest.java b/src/test/java/org/apache/juneau/releng/log/RunLogTest.java
index 560e6a6960..e64650674a 100644
--- a/src/test/java/org/apache/juneau/releng/log/RunLogTest.java
+++ b/src/test/java/org/apache/juneau/releng/log/RunLogTest.java
@@ -31,6 +31,9 @@ class RunLogTest {
 	// convention is applied by the caller when constructing one RunLog per step.
 
 	@Test
+	@SuppressWarnings({
+		"try" // Subscription is held only so close() unsubscribes at scope exit; the body never reads it.
+	})
 	void a01_appendsToDiskAndFansOutToBroadcaster(@TempDir Path dir) throws Exception {
 		var bc = new LogBroadcaster();
 		var got = new ArrayList<String>();
@@ -54,6 +57,9 @@ class RunLogTest {
 	}
 
 	@Test
+	@SuppressWarnings({
+		"try" // Subscription is held only so close() unsubscribes at scope exit; the body never reads it.
+	})
 	void a03_lineSinkFeedsBothDiskAndBroadcaster(@TempDir Path dir) throws Exception {
 		var bc = new LogBroadcaster();
 		var got = new ArrayList<String>();
diff --git a/src/test/java/org/apache/juneau/releng/log/RunStateBroadcasterTest.java b/src/test/java/org/apache/juneau/releng/log/RunStateBroadcasterTest.java
index d866d39e41..6117883316 100644
--- a/src/test/java/org/apache/juneau/releng/log/RunStateBroadcasterTest.java
+++ b/src/test/java/org/apache/juneau/releng/log/RunStateBroadcasterTest.java
@@ -25,6 +25,9 @@ import org.junit.jupiter.api.Test;
 class RunStateBroadcasterTest {
 
 	@Test
+	@SuppressWarnings({
+		"try" // Subscription is held only so close() unsubscribes at scope exit; the body never reads it.
+	})
 	void a01_publishDeliversToEverySubscriber() throws Exception {
 		var bc = new RunStateBroadcaster();
 		var a = new ArrayList<String>();
@@ -51,6 +54,9 @@ class RunStateBroadcasterTest {
 	}
 
 	@Test
+	@SuppressWarnings({
+		"try" // Subscription is held only so close() unsubscribes at scope exit; the body never reads it.
+	})
 	void a03_aThrowingSubscriberDoesNotBreakOthers() throws Exception {
 		var bc = new RunStateBroadcaster();
 		var seen = new ArrayList<String>();