[GitHub] [incubator-pinot] snleee commented on a change in pull request #3925: readthedocs: Add contribution guidelines

[GitBox <gi...@apache.org>]

snleee commented on a change in pull request #3925: readthedocs: Add contribution guidelines
URL: https://github.com/apache/incubator-pinot/pull/3925#discussion_r263526469
 
 

 ##########
 File path: docs/contribution_guidelines.rst
 ##########
 @@ -54,13 +126,79 @@ All source code files should have license headers. To automatically add the head
 
 .. note::
 
-If you checkin third-party code or files, do not add license headers for them. Follow these instructions to ensure we
-are compliant with Apache Licensing process. <TBD>
+If you checkin third-party code or files, ensure they are distributed under Apache, MIT or BSD-3 licenses.
 
 Review comment:
   Let's put the link for the below page. It gives us the extensive list of allowed/not-allowed licenses
   https://www.apache.org/legal/resolved.html#what-can-we-include-in-an-asf-project-category-a
   https://www.apache.org/legal/resolved.html#what-can-we-maybe-include-in-an-asf-project-category-b
   https://www.apache.org/legal/resolved.html#what-can-we-not-include-in-an-asf-project-category-x

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org