You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/08/07 15:40:12 UTC

[jira] [Commented] (THRIFT-2651) struct names that are restricted erlang terms generate invalid type signatures

    [ https://issues.apache.org/jira/browse/THRIFT-2651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14089216#comment-14089216 ] 

ASF GitHub Bot commented on THRIFT-2651:
----------------------------------------

GitHub user talentdeficit opened a pull request:

    https://github.com/apache/thrift/pull/176

    THRIFT-2651: struct names that are restricted erlang terms generate inva...

    ...lid type signatures
    
    patch: alisdairsullivan@yahoo.ca
    client: erlang
    
    fixes error exposed in THRIFT-2647 by avoiding using restricted identifiers in erlang type signatures generated by the compiler

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/talentdeficit/thrift thrift-2651

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/176.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #176
    
----
commit 156e344023b22331d680ff4d4f3ac3a295a1dc13
Author: alisdair sullivan <al...@yahoo.ca>
Date:   2014-08-07T13:32:37Z

    THRIFT-2651: struct names that are restricted erlang terms generate invalid type signatures
    
    patch: alisdairsullivan@yahoo.ca
    client: erlang
    
    fixes error exposed in THRIFT-2647 by avoiding using restricted identifiers in erlang type signatures generated by the compiler

----


> struct names that are restricted erlang terms generate invalid type signatures
> ------------------------------------------------------------------------------
>
>                 Key: THRIFT-2651
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2651
>             Project: Thrift
>          Issue Type: Bug
>          Components: Erlang - Compiler
>            Reporter: alisdair sullivan
>              Labels: erlang
>
> fixes error exposed in THRIFT-2647 by avoiding using restricted identifiers in erlang type signatures generated by the compiler



--
This message was sent by Atlassian JIRA
(v6.2#6252)