You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by ae...@apache.org on 2019/09/17 23:05:58 UTC
[hadoop] branch trunk updated: HDFS-14846: libhdfs tests are
failing on trunk due to jni usage bugs
This is an automated email from the ASF dual-hosted git repository.
aengineer pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/trunk by this push:
new 3cf6e42 HDFS-14846: libhdfs tests are failing on trunk due to jni usage bugs
3cf6e42 is described below
commit 3cf6e4272f192c69a161307ad9d35142c5a845c5
Author: Sahil Takiar <ta...@gmail.com>
AuthorDate: Thu Sep 12 15:51:05 2019 -0700
HDFS-14846: libhdfs tests are failing on trunk due to jni usage bugs
Signed-off-by: Anu Engineer <ae...@apache.org>
---
.../native/src/org/apache/hadoop/security/JniBasedUnixGroupsMapping.c | 3 ---
.../src/main/native/libhdfs-tests/native_mini_dfs.c | 2 +-
.../hadoop-hdfs-native-client/src/main/native/libhdfs/hdfs.c | 1 -
3 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/security/JniBasedUnixGroupsMapping.c b/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/security/JniBasedUnixGroupsMapping.c
index 402ffd5..b463679 100644
--- a/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/security/JniBasedUnixGroupsMapping.c
+++ b/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/security/JniBasedUnixGroupsMapping.c
@@ -199,8 +199,5 @@ done:
if (ginfo) {
hadoop_group_info_free(ginfo);
}
- if (jgroupname) {
- (*env)->DeleteLocalRef(env, jgroupname);
- }
return jgroups;
}
diff --git a/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfs-tests/native_mini_dfs.c b/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfs-tests/native_mini_dfs.c
index 3af56f1..a69c6ef 100644
--- a/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfs-tests/native_mini_dfs.c
+++ b/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfs-tests/native_mini_dfs.c
@@ -184,8 +184,8 @@ struct NativeMiniDfsCluster* nmdCreate(struct NativeMiniDfsConf *conf)
"Builder::numDataNodes");
goto error;
}
+ (*env)->DeleteLocalRef(env, val.l);
}
- (*env)->DeleteLocalRef(env, val.l);
jthr = findClassAndInvokeMethod(env, &val, INSTANCE, bld, MINIDFS_CLUSTER_BUILDER,
"build", "()L" MINIDFS_CLUSTER ";");
if (jthr) {
diff --git a/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfs/hdfs.c b/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfs/hdfs.c
index b8442b4..e6b2010 100644
--- a/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfs/hdfs.c
+++ b/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfs/hdfs.c
@@ -3480,7 +3480,6 @@ done:
destroyLocalReference(env, jUserName);
destroyLocalReference(env, jGroupName);
destroyLocalReference(env, jPermission);
- destroyLocalReference(env, jPath);
return jthr;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org