You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "maarten-donderwinkel (via GitHub)" <gi...@apache.org> on 2023/08/11 14:02:37 UTC
[GitHub] [camel] maarten-donderwinkel opened a new pull request, #11087: [CAMEL-19736] Add 'secret' as sensitive key for logging purposes.
maarten-donderwinkel opened a new pull request, #11087:
URL: https://github.com/apache/camel/pull/11087
# Description
Add 'secret' as sensitive data for masking purposes in logs.
Often we us 'secret' as (last) part of an environmentVariable especially if that matches the naming convention of an external party to keep easier overview of application & variables.
However these values aren't masked in the logging (as username/password are).
Add 'secret' as potentially sensitive data.
# Target
- [X] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [X] If this is a large change, bug fix, or code improvement, I checked there is a [CAMEL-19736](https://issues.apache.org/jira/browse/CAMEL-19736)
# Apache Camel coding standards and style
- [X] I checked that each commit in the pull request has a meaningful subject line and body.
- [X] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #11087: [CAMEL-19736] Add 'secret' as sensitive key for logging purposes.
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #11087:
URL: https://github.com/apache/camel/pull/11087
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #11087: [CAMEL-19736] Add 'secret' as sensitive key for logging purposes.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11087:
URL: https://github.com/apache/camel/pull/11087#issuecomment-1674846914
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:camel: Maintainers, please note that first-time contributors *require manual approval* for the GitHub Actions to run.
:warning: Please note that the changes on this PR may be **tested automatically** if they change components.
:robot: Use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #11087: [CAMEL-19736] Add 'secret' as sensitive key for logging purposes.
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #11087:
URL: https://github.com/apache/camel/pull/11087#issuecomment-1674883391
yes add it to extra keys, and keep the test as we want to ensure its in the generated source code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] maarten-donderwinkel commented on pull request #11087: [CAMEL-19736] Add 'secret' as sensitive key for logging purposes.
Posted by "maarten-donderwinkel (via GitHub)" <gi...@apache.org>.
maarten-donderwinkel commented on PR #11087:
URL: https://github.com/apache/camel/pull/11087#issuecomment-1674876403
> the file is generated
>
> ```
> // Generated by camel build tools - do NOT edit this list!
> // SENSITIVE-KEYS: START
> ```
>
> Search for `SENSITIVE-KEYS: START` and find the source generator that does this, and add the secret into it there
Will do, should the line also be removed from the test?
And as I'm not a 100% sure you mean adding this to the EXTRA KEYS in UpdateSensitizeHelper right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #11087: [CAMEL-19736] Add 'secret' as sensitive key for logging purposes.
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #11087:
URL: https://github.com/apache/camel/pull/11087#issuecomment-1674945804
error not related
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org