You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2023/05/06 05:54:55 UTC

[GitHub] [flink-connector-pulsar] tisonkun opened a new pull request, #44: [FLINK-32003] Upgrade pulsar-client version to work with OAuth2

tisonkun opened a new pull request, #44:
URL: https://github.com/apache/flink-connector-pulsar/pull/44

   ## Purpose of the change
   
   Upgrade pulsar-client version to work with OAuth2
   
   ## Verifying this change
   
   Existing tests should pass.
   
   ## Significant changes
   
   *(Please check any boxes [x] if the answer is "yes". You can first publish the PR and check them afterwards, for
   convenience.)*
   
   - [x] Dependencies have been added or upgraded
   - [ ] Public API has been changed (Public API is any class annotated with `@Public(Evolving)`)
   - [ ] Serializers have been changed
   - [ ] New feature has been introduced
       - If yes, how is this documented? (not applicable / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-connector-pulsar] tisonkun commented on pull request #44: [FLINK-32003] Upgrade pulsar-client version to work with OAuth2

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #44:
URL: https://github.com/apache/flink-connector-pulsar/pull/44#issuecomment-1537071531

   Emm...It seems that plugin is default to skip.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-connector-pulsar] tisonkun commented on pull request #44: [FLINK-32003] Upgrade pulsar-client version to work with OAuth2

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #44:
URL: https://github.com/apache/flink-connector-pulsar/pull/44#issuecomment-1537095518

   Pending for merging...
   
   Although, I suggest a release is required to deliver this fix to downstream users.
   
   cc @MartijnVisser @leonardBang @dannycranmer what do you think and how can I help in release?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-connector-pulsar] tisonkun commented on pull request #44: [FLINK-32003] Upgrade pulsar-client version to work with OAuth2

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #44:
URL: https://github.com/apache/flink-connector-pulsar/pull/44#issuecomment-1537073378

   @reswqa I manually disable skip. But the default config seems:
   
   ```
                           <plugin>
                               <groupId>com.diffplug.spotless</groupId>
                               <artifactId>spotless-maven-plugin</artifactId>
                               <configuration>
                                   <skip>true</skip>
                               </configuration>
                           </plugin>
   ```
   
   in `flink-connector-parent-1.0.pom`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-connector-pulsar] tisonkun commented on pull request #44: [FLINK-32003] Upgrade pulsar-client version to work with OAuth2

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #44:
URL: https://github.com/apache/flink-connector-pulsar/pull/44#issuecomment-1537078809

   Still a few breaking things.
   
   I'm trying to pick https://github.com/apache/flink/pull/21204.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-connector-pulsar] reswqa commented on pull request #44: [FLINK-32003] Upgrade pulsar-client version to work with OAuth2

Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on PR #44:
URL: https://github.com/apache/flink-connector-pulsar/pull/44#issuecomment-1537070591

   It seems that we have some format violations.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-connector-pulsar] tisonkun commented on pull request #44: [FLINK-32003] Upgrade pulsar-client version to work with OAuth2

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #44:
URL: https://github.com/apache/flink-connector-pulsar/pull/44#issuecomment-1537071088

   Werid. I run already `mvn spotless:apply` and no diff report.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-connector-pulsar] tisonkun merged pull request #44: [FLINK-32003] Upgrade pulsar-client version to work with OAuth2

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #44:
URL: https://github.com/apache/flink-connector-pulsar/pull/44


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-connector-pulsar] tisonkun commented on pull request #44: [FLINK-32003] Upgrade pulsar-client version to work with OAuth2

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #44:
URL: https://github.com/apache/flink-connector-pulsar/pull/44#issuecomment-1537068806

   Change to builder which is a compatible way - test compile from 2.10.1 to 2.10.4.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-connector-pulsar] reswqa commented on pull request #44: [FLINK-32003] Upgrade pulsar-client version to work with OAuth2

Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on PR #44:
URL: https://github.com/apache/flink-connector-pulsar/pull/44#issuecomment-1537072197

   > Werid. I run already mvn spotless:apply and no diff report.
   
   Did you manually execute `mvn spotless: apply`, which successfully fixed the formatting issue on my mac.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-connector-pulsar] tisonkun commented on pull request #44: [FLINK-32003] Upgrade pulsar-client version to work with OAuth2

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #44:
URL: https://github.com/apache/flink-connector-pulsar/pull/44#issuecomment-1537065990

   @nlu90 No luck - Pulsar patch release breaks interface:
   
   ```
   Error:  COMPILATION ERROR : 
   [INFO] -------------------------------------------------------------
   Error:  /home/runner/work/flink-connector-pulsar/flink-connector-pulsar/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/common/schema/PulsarSchemaUtils.java:[184,16] no suitable constructor found for SchemaInfoImpl(java.lang.String,byte[],org.apache.pulsar.common.schema.SchemaType,java.util.Map<java.lang.String,java.lang.String>)
       constructor org.apache.pulsar.client.impl.schema.SchemaInfoImpl.SchemaInfoImpl(java.lang.String,byte[],org.apache.pulsar.common.schema.SchemaType,long,java.util.Map<java.lang.String,java.lang.String>) is not applicable
         (actual and formal argument lists differ in length)
       constructor org.apache.pulsar.client.impl.schema.SchemaInfoImpl.SchemaInfoImpl() is not applicable
         (actual and formal argument lists differ in length)
   Error:  /home/runner/work/flink-connector-pulsar/flink-connector-pulsar/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/common/schema/PulsarSchema.java:[180,27] no suitable constructor found for SchemaInfoImpl(java.lang.String,byte[],org.apache.pulsar.common.schema.SchemaType,java.util.Map<java.lang.String,java.lang.String>)
       constructor org.apache.pulsar.client.impl.schema.SchemaInfoImpl.SchemaInfoImpl(java.lang.String,byte[],org.apache.pulsar.common.schema.SchemaType,long,java.util.Map<java.lang.String,java.lang.String>) is not applicable
         (actual and formal argument lists differ in length)
       constructor org.apache.pulsar.client.impl.schema.SchemaInfoImpl.SchemaInfoImpl() is not applicable
         (actual and formal argument lists differ in length)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-connector-pulsar] tisonkun commented on pull request #44: [FLINK-32003] Upgrade pulsar-client version to work with OAuth2

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #44:
URL: https://github.com/apache/flink-connector-pulsar/pull/44#issuecomment-1537091245

   I'm feeling lucky now ;-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org