You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/28 18:28:17 UTC
[GitHub] [arrow] jorgecarleitao opened a new pull request #9353: ARROW-11420: [Rust] Removed usage of `unsafe`.
jorgecarleitao opened a new pull request #9353:
URL: https://github.com/apache/arrow/pull/9353
This is just a small simplification that was enabled by the recent PR #9215. 1 less unneeded `unsafe`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9353: ARROW-11420: [Rust] Added support to length of Binary and List.
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9353:
URL: https://github.com/apache/arrow/pull/9353#issuecomment-782838543
@jorgecarleitao I think this one is ready to go -- it just needs a rebase and then merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9353: ARROW-11420: [Rust] Added support to length of Binary and List.
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9353:
URL: https://github.com/apache/arrow/pull/9353#issuecomment-822358800
The Apache Arrow Rust community is moving the Rust implementation into its own dedicated github repositories [arrow-rs](https://github.com/apache/arrow-rs) and [arrow-datafusion](https://github.com/apache/arrow-datafusion). It is likely we will not merge this PR into this repository
Please see the [mailing-list](https://lists.apache.org/thread.html/rce7c61cb3f703367dc00984530016e3fcb828e5a8035655fbcccf862%40%3Cdev.arrow.apache.org%3E) thread for more details
We expect the process to take a few days and will follow up with a migration plan for the in-flight PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9353: ARROW-11420: [Rust] Added support to length of Binary and List.
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9353:
URL: https://github.com/apache/arrow/pull/9353#issuecomment-778135054
@jorgecarleitao -- this one needs a rebase and then I think it is ready to go
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me commented on a change in pull request #9353: ARROW-11420: [Rust] Added support to length of Binary and List.
Posted by GitBox <gi...@apache.org>.
nevi-me commented on a change in pull request #9353:
URL: https://github.com/apache/arrow/pull/9353#discussion_r575168065
##########
File path: rust/arrow/src/compute/kernels/length.rs
##########
@@ -24,42 +24,77 @@ use crate::{
};
use std::sync::Arc;
-fn length_string<OffsetSize>(array: &Array, data_type: DataType) -> Result<ArrayRef>
-where
- OffsetSize: OffsetSizeTrait,
-{
- // note: offsets are stored as u8, but they can be interpreted as OffsetSize
- let offsets = &array.data_ref().buffers()[0];
- // this is a 30% improvement over iterating over u8s and building OffsetSize, which
- // justifies the usage of `unsafe`.
- let slice: &[OffsetSize] =
- &unsafe { offsets.typed_data::<OffsetSize>() }[array.offset()..];
+fn clone_null_buffer(array: &impl Array) -> Option<Buffer> {
+ array
+ .data_ref()
+ .null_bitmap()
Review comment:
`.null_buffer().cloned()` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9353: ARROW-11420: [Rust] Removed usage of `unsafe`.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9353:
URL: https://github.com/apache/arrow/pull/9353#issuecomment-769298206
https://issues.apache.org/jira/browse/ARROW-11420
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9353: ARROW-11420: [Rust] Added support to length of Binary and List.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9353:
URL: https://github.com/apache/arrow/pull/9353#issuecomment-769330191
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9353?src=pr&el=h1) Report
> Merging [#9353](https://codecov.io/gh/apache/arrow/pull/9353?src=pr&el=desc) (48d78ca) into [master](https://codecov.io/gh/apache/arrow/commit/2fd5857c625874845ce02569821ee54d8ca9b9d2?el=desc) (2fd5857) will **decrease** coverage by `0.02%`.
> The diff coverage is `74.54%`.
[](https://codecov.io/gh/apache/arrow/pull/9353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9353 +/- ##
==========================================
- Coverage 81.97% 81.95% -0.03%
==========================================
Files 216 216
Lines 53227 53270 +43
==========================================
+ Hits 43633 43657 +24
- Misses 9594 9613 +19
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/datafusion/src/physical\_plan/functions.rs](https://codecov.io/gh/apache/arrow/pull/9353/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2Z1bmN0aW9ucy5ycw==) | `71.80% <55.55%> (-0.50%)` | :arrow_down: |
| [rust/arrow/src/compute/kernels/length.rs](https://codecov.io/gh/apache/arrow/pull/9353/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2xlbmd0aC5ycw==) | `88.61% <78.26%> (-11.39%)` | :arrow_down: |
| [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9353/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `94.86% <0.00%> (-0.20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9353?src=pr&el=footer). Last update [2fd5857...48d78ca](https://codecov.io/gh/apache/arrow/pull/9353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao closed pull request #9353: ARROW-11420: [Rust] Added support to length of Binary and List.
Posted by GitBox <gi...@apache.org>.
jorgecarleitao closed pull request #9353:
URL: https://github.com/apache/arrow/pull/9353
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org