You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/05/09 11:09:12 UTC
[jira] [Commented] (KAFKA-3679) Allow reuse of implementation of
RFC 4616 in PlainSaslServer
[ https://issues.apache.org/jira/browse/KAFKA-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15276225#comment-15276225 ]
ASF GitHub Bot commented on KAFKA-3679:
---------------------------------------
GitHub user edoardocomar opened a pull request:
https://github.com/apache/kafka/pull/1350
KAFKA-3679 Allow reuse of implementation of RFC 4616 in PlainSaslServer
extracted authorize(username,password) from evaluateResponse(bytes)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/edoardocomar/kafka KAFKA-3679
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1350.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1350
----
commit f53240bf1de1a130d6b3e6f29aa38a30f4aeda35
Author: edoardo <ec...@uk.ibm.com>
Date: 2016-05-09T10:54:34Z
KAFKA-3679 Allow reuse of implementation of RFC 4616 in PlainSaslServer
extracted authorize(username,password) from evaluateResponse(bytes)
----
> Allow reuse of implementation of RFC 4616 in PlainSaslServer
> -------------------------------------------------------------
>
> Key: KAFKA-3679
> URL: https://issues.apache.org/jira/browse/KAFKA-3679
> Project: Kafka
> Issue Type: Improvement
> Components: clients
> Affects Versions: 0.10.0.0
> Reporter: Edoardo Comar
> Assignee: Edoardo Comar
>
> Using SASL PLAIN in production may require a different username/password checking than what is currently in the codebase, based on data contained in the server jaas.conf.
> To do so, a deployment needs to extend the SaslPlainServer as described here
> http://kafka.apache.org/0100/documentation.html#security_sasl_plain_production
> However the evaluate(byes) method still needs to impleemnt RFC4616, so it is useful to separate the password checking from the reading of the data from the wire.
> A simple extract method into an overridable methos should suffice
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)