[GitHub] [pinot] somandal commented on a diff in pull request #10248: [multi-stage] Support query plan for GROUP BY only in the intermediary stage

["somandal (via GitHub)" <gi...@apache.org>]

somandal commented on code in PR #10248:
URL: https://github.com/apache/pinot/pull/10248#discussion_r1110445496


##########
pinot-query-planner/src/test/resources/queries/GroupByPlans.json:
##########
@@ -91,6 +91,92 @@
           "\n                  LogicalTableScan(table=[[a]])",
           "\n"
         ]
+      },
+      {
+        "description": "SQL hint based group by optimization with select and aggregate column",

Review Comment:
   From my understanding of the code this hint can potentially be used for the following types of queries in addition to the group by queries tested here:
   
   - Select only aggregation columns with group-by (e.g. `SELECT SUM(a.col3) FROM a GROUP BY a.col3`)
   - Select only aggregation columns without group by (e.g. `SELECT SUM(a.col3) FROM a`)
   
   Do you intend this hint to act on the above type of queries?
   If so, can you add some test cases for the above?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org