You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2022/04/21 23:16:37 UTC
[commons-beanutils] branch master updated (f7d03b74 -> 402b3701)
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-beanutils.git
from f7d03b74 Fix SpotBugs error.
new 118607f1 Format: remove extra blank lines.
new 402b3701 [ERROR] Medium: org.apache.commons.beanutils2.converters.ArrayConverter.setAllowedChars(char[]) may expose internal representation by storing an externally mutable object into ArrayConverter.allowedChars [org.apache.commons.beanutils2.converters.ArrayConverter] At ArrayConverter.java:[line 202] EI_EXPOSE_REP2
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
src/changes/changes.xml | 3 +++
.../org/apache/commons/beanutils2/converters/ArrayConverter.java | 3 ++-
.../apache/commons/beanutils2/converters/DateTimeConverter.java | 7 -------
3 files changed, 5 insertions(+), 8 deletions(-)
[commons-beanutils] 02/02: [ERROR] Medium: org.apache.commons.beanutils2.converters.ArrayConverter.setAllowedChars(char[]) may expose internal representation by storing an externally mutable object into ArrayConverter.allowedChars [org.apache.commons.beanutils2.converters.ArrayConverter] At ArrayConverter.java:[line 202] EI_EXPOSE_REP2
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-beanutils.git
commit 402b37017ca5458617f85711cb4fac0ff54d8c59
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Thu Apr 21 19:16:32 2022 -0400
[ERROR] Medium:
org.apache.commons.beanutils2.converters.ArrayConverter.setAllowedChars(char[])
may expose internal representation by storing an externally mutable
object into ArrayConverter.allowedChars
[org.apache.commons.beanutils2.converters.ArrayConverter] At
ArrayConverter.java:[line 202] EI_EXPOSE_REP2
---
src/changes/changes.xml | 3 +++
.../java/org/apache/commons/beanutils2/converters/ArrayConverter.java | 3 ++-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index c47d750e..54b4cb3b 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -86,6 +86,9 @@
<action dev="ggregory" type="fix" due-to="Gary Gregory">
Fix SpotBugs [ERROR] Medium: Unused public or protected field: org.apache.commons.beanutils2.WrapDynaClass.descriptors [org.apache.commons.beanutils2.WrapDynaClass] In WrapDynaClass.java UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD.
</action>
+ <action dev="ggregory" type="fix" due-to="Gary Gregory">
+ Fix SpotBugs [ERROR] Medium: org.apache.commons.beanutils2.converters.ArrayConverter.setAllowedChars(char[]) may expose internal representation by storing an externally mutable object into ArrayConverter.allowedChars [org.apache.commons.beanutils2.converters.ArrayConverter] At ArrayConverter.java:[line 202] EI_EXPOSE_REP2.
+ </action>
<!-- UPDATES -->
<action dev="ggregory" type="update" due-to="Dependabot, Gary Gregory">
Bump actions/cache from 2 to 3.0.2 #77, #89, #103, #111.
diff --git a/src/main/java/org/apache/commons/beanutils2/converters/ArrayConverter.java b/src/main/java/org/apache/commons/beanutils2/converters/ArrayConverter.java
index edf93bf2..2449791a 100644
--- a/src/main/java/org/apache/commons/beanutils2/converters/ArrayConverter.java
+++ b/src/main/java/org/apache/commons/beanutils2/converters/ArrayConverter.java
@@ -25,6 +25,7 @@ import java.util.Collection;
import java.util.Collections;
import java.util.Iterator;
import java.util.List;
+import java.util.Objects;
import org.apache.commons.beanutils2.ConversionException;
import org.apache.commons.beanutils2.Converter;
@@ -199,7 +200,7 @@ public class ArrayConverter extends AbstractConverter {
* the tokens when parsing a delimited String [default is '.' and '-']
*/
public void setAllowedChars(final char[] allowedChars) {
- this.allowedChars = allowedChars;
+ this.allowedChars = Objects.requireNonNull(allowedChars, "allowedChars").clone();
}
/**
[commons-beanutils] 01/02: Format: remove extra blank lines.
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-beanutils.git
commit 118607f15ae0456c79dd5ea2f02d5137716f0a55
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Thu Apr 21 19:15:44 2022 -0400
Format: remove extra blank lines.
---
.../apache/commons/beanutils2/converters/DateTimeConverter.java | 7 -------
1 file changed, 7 deletions(-)
diff --git a/src/main/java/org/apache/commons/beanutils2/converters/DateTimeConverter.java b/src/main/java/org/apache/commons/beanutils2/converters/DateTimeConverter.java
index 6b218917..f2e531b8 100644
--- a/src/main/java/org/apache/commons/beanutils2/converters/DateTimeConverter.java
+++ b/src/main/java/org/apache/commons/beanutils2/converters/DateTimeConverter.java
@@ -98,8 +98,6 @@ public abstract class DateTimeConverter extends AbstractConverter {
private TimeZone timeZone;
private boolean useLocaleFormat;
-
-
/**
* Constructs a Date/Time <i>Converter</i> that throws a
* {@code ConversionException} if an error occurs.
@@ -119,8 +117,6 @@ public abstract class DateTimeConverter extends AbstractConverter {
super(defaultValue);
}
-
-
/**
* Indicate whether conversion should use a format/pattern or not.
*
@@ -208,8 +204,6 @@ public abstract class DateTimeConverter extends AbstractConverter {
setUseLocaleFormat(true);
}
-
-
/**
* Convert an input Date/Calendar object into a String.
* <p>
@@ -383,7 +377,6 @@ public abstract class DateTimeConverter extends AbstractConverter {
// Default String conversion
return toDate(targetType, stringValue);
-
}
/**