You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Laszlo Gaal (Code Review)" <ge...@cloudera.org> on 2023/12/08 18:24:30 UTC

[Impala-ASF-CR] IMPALA-12590: Fix dmesg call during precommit for Ubuntu 20.04

Laszlo Gaal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20763


Change subject: IMPALA-12590: Fix dmesg call during precommit for Ubuntu 20.04
......................................................................

IMPALA-12590: Fix dmesg call during precommit for Ubuntu 20.04

Ubuntu 20.04 locked down access to the kernel messages, so a call to
'dmesg' can succeed only when executed with elevated privileges.

This could be a problem during Impala precommit runs, as the finalizer
script uses 'dmesg' to detect potential OOM-kills during the run.

This patch adds an "escalation" step to the dmesg call: if the regular
call fails, it issues a second call via 'sudo'.

Change-Id: Ic20193740c6e5cb9e8e155c03bede55184875de5
---
M bin/jenkins/finalize.sh
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/20763/1
-- 
To view, visit http://gerrit.cloudera.org:8080/20763
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic20193740c6e5cb9e8e155c03bede55184875de5
Gerrit-Change-Number: 20763
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>

[Impala-ASF-CR] IMPALA-12590: Fix dmesg call during precommit for Ubuntu 20.04

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20763 )

Change subject: IMPALA-12590: Fix dmesg call during precommit for Ubuntu 20.04
......................................................................

IMPALA-12590: Fix dmesg call during precommit for Ubuntu 20.04

Ubuntu 20.04 locked down access to the kernel messages, so a call to
'dmesg' can succeed only when executed with elevated privileges.

This could be a problem during Impala precommit runs, as the finalizer
script uses 'dmesg' to detect potential OOM-kills during the run.

This patch adds an "escalation" step to the dmesg call: if the regular
call fails, it issues a second call via 'sudo'.

Change-Id: Ic20193740c6e5cb9e8e155c03bede55184875de5
Reviewed-on: http://gerrit.cloudera.org:8080/20763
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/jenkins/finalize.sh
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/20763
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic20193740c6e5cb9e8e155c03bede55184875de5
Gerrit-Change-Number: 20763
Gerrit-PatchSet: 3
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>

[Impala-ASF-CR] IMPALA-12590: Fix dmesg call during precommit for Ubuntu 20.04

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20763 )

Change subject: IMPALA-12590: Fix dmesg call during precommit for Ubuntu 20.04
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/20763
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic20193740c6e5cb9e8e155c03bede55184875de5
Gerrit-Change-Number: 20763
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Sat, 20 Jan 2024 18:17:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12590: Fix dmesg call during precommit for Ubuntu 20.04

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20763 )

Change subject: IMPALA-12590: Fix dmesg call during precommit for Ubuntu 20.04
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10182/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/20763
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic20193740c6e5cb9e8e155c03bede55184875de5
Gerrit-Change-Number: 20763
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Sat, 20 Jan 2024 13:48:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12590: Fix dmesg call during precommit for Ubuntu 20.04

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20763 )

Change subject: IMPALA-12590: Fix dmesg call during precommit for Ubuntu 20.04
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/14626/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20763
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic20193740c6e5cb9e8e155c03bede55184875de5
Gerrit-Change-Number: 20763
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Dec 2023 18:53:17 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12590: Fix dmesg call during precommit for Ubuntu 20.04

Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/20763 )

Change subject: IMPALA-12590: Fix dmesg call during precommit for Ubuntu 20.04
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/20763
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic20193740c6e5cb9e8e155c03bede55184875de5
Gerrit-Change-Number: 20763
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Thu, 18 Jan 2024 15:46:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12590: Fix dmesg call during precommit for Ubuntu 20.04

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20763 )

Change subject: IMPALA-12590: Fix dmesg call during precommit for Ubuntu 20.04
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/20763
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic20193740c6e5cb9e8e155c03bede55184875de5
Gerrit-Change-Number: 20763
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Dec 2023 21:56:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12590: Fix dmesg call during precommit for Ubuntu 20.04

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20763 )

Change subject: IMPALA-12590: Fix dmesg call during precommit for Ubuntu 20.04
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/20763
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic20193740c6e5cb9e8e155c03bede55184875de5
Gerrit-Change-Number: 20763
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Sat, 20 Jan 2024 13:48:52 +0000
Gerrit-HasComments: No