[GitHub] [beam] benWize commented on a change in pull request #15742: [BEAM-11936] Fix errorprone warning: UnusedVariable

[GitBox <gi...@apache.org>]

benWize commented on a change in pull request #15742:
URL: https://github.com/apache/beam/pull/15742#discussion_r747005290



##########
File path: runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/util/common/worker/MapTaskExecutor.java
##########
@@ -72,9 +69,7 @@ public void execute() throws Exception {
     // Save the current thread that is executing so that abort() can interrupt it, we save it before
     // starting the progress reporter thread, therefore ensuring thread safety through implicit
     // serialization of events.
-    synchronized (this) {
-      this.currentExecutorThread = Thread.currentThread();
-    }
+    // Current thread that execute() is running on; null when not running.

Review comment:
       Removed

##########
File path: examples/java/src/main/java/org/apache/beam/examples/cookbook/JoinExamples.java
##########
@@ -93,7 +93,7 @@
                   public void processElement(ProcessContext c) {
                     KV<String, CoGbkResult> e = c.element();
                     String countryCode = e.getKey();
-                    String countryName = "none";
+                    String countryName;

Review comment:
       Done!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org