[GitHub] mgaido91 commented on a change in pull request #23285: [SPARK-26224][SQL] Warn and advice the user when creating many project on subsequent calls to withColumn

[GitBox <gi...@apache.org>]

mgaido91 commented on a change in pull request #23285: [SPARK-26224][SQL] Warn and advice the user when creating many project on subsequent calls to withColumn
URL: https://github.com/apache/spark/pull/23285#discussion_r242329937
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
 ##########
 @@ -2154,6 +2155,18 @@ class Dataset[T] private[sql](
       colNames,
       "in given column names",
       sparkSession.sessionState.conf.caseSensitiveAnalysis)
+    var numProjects = 0
+    var currPlan = logicalPlan
+    while (currPlan.isInstanceOf[Project] && numProjects < 50) {
 
 Review comment:
   yes, I just wanted to be sure that we agree on the idea. Do you have hint/preferences for the name of the config?
   I didn't want to introduce a high value in order not to have a high impact on perf for the loop to check this. What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org