[GitHub] [pinot] siddharthteotia commented on pull request #7210: Support EXPLAIN PLAN

[GitBox <gi...@apache.org>]

siddharthteotia commented on pull request #7210:
URL: https://github.com/apache/pinot/pull/7210#issuecomment-887147283


   > I will review the design doc once I get the access. High level comment.
   > 
   > This is a lot of code and it looks like we are creating a completely different code path for explain. This can get outdated and out of sync. We should have extended the operator interface to add explain implementation.
   > 
   > I will review the design doc and add more comments. But please hold off on merging this
   
   @kishoreg  We had shared the design doc a month ago on the mailing list and then proceeded with implementation. 
   
   Vast majority of LOCs are coming from exhaustive functional test class file. 
   
   Please spend some time reviewing. Happy to address feedback. We can also meet to discuss. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org