You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by jk...@apache.org on 2014/05/27 07:50:55 UTC
svn commit: r1597706 - /httpd/httpd/branches/2.2.x/STATUS
Author: jkaluza
Date: Tue May 27 05:50:54 2014
New Revision: 1597706
URL: http://svn.apache.org/r1597706
Log:
Vote, propose additional PR 50317 (thundering herd) fix.
Modified:
httpd/httpd/branches/2.2.x/STATUS
Modified: httpd/httpd/branches/2.2.x/STATUS
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/STATUS?rev=1597706&r1=1597705&r2=1597706&view=diff
==============================================================================
--- httpd/httpd/branches/2.2.x/STATUS (original)
+++ httpd/httpd/branches/2.2.x/STATUS Tue May 27 05:50:54 2014
@@ -126,7 +126,7 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
trunk patch: http://svn.apache.org/viewvc?view=revision&revision=1023398
2.2.x patch: http://people.apache.org/~covener/patches/httpd-2.2.x-thunder.diff
(+ CHANGES)
- +1: covener
+ +1: covener, jkaluza
* mod_rewrite: Support session cookies with the CO= flag when later parameters
are used. The doc for this implied the feature had been backported for
@@ -135,6 +135,16 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
2.2.x patch: http://people.apache.org/~covener/patches/httpd-2.2.x-rewrite-sessioncookie.diff
+1 covener
+ * mod_cache, mod_disk_cache: Try to use the key of a possible open but
+ stale cache entry if there is one. This fixes problem when two different
+ cache locks have been created for single stale cache entry leading to two
+ requests sent to backend.
+ Remove useless apr_file_remove() before renaming the cache entry in
+ mod_disk_cache. This fixes small time-frame during which stale cache
+ entry can be seen as not-cached.
+ PR 50317
+ 2.2.x patch: http://people.apache.org/~jkaluza/patches/httpd-2.2.x-thundering-herd.patch
+
PATCHES/ISSUES THAT ARE STALLED
* mod_cache: Realign the cache_quick_handler() to behave identically
RE: svn commit: r1597706 - /httpd/httpd/branches/2.2.x/STATUS
Posted by Plüm,
Rüdiger,
Vodafone Group <ru...@vodafone.com>.
> -----Original Message-----
> From: Eric Covener
> Sent: Montag, 7. Juli 2014 00:16
> To: Apache HTTP Server Development List
> Subject: Re: svn commit: r1597706 - /httpd/httpd/branches/2.2.x/STATUS
>
> > + * mod_cache, mod_disk_cache: Try to use the key of a possible open
> but
> > + stale cache entry if there is one. This fixes problem when two
> different
> > + cache locks have been created for single stale cache entry leading
> to two
> > + requests sent to backend.
> > + Remove useless apr_file_remove() before renaming the cache entry
> in
> > + mod_disk_cache. This fixes small time-frame during which stale
> cache
> > + entry can be seen as not-cached.
> > + PR 50317
> > + 2.2.x patch: http://people.apache.org/~jkaluza/patches/httpd-
> 2.2.x-thundering-herd.patch
> > +
>
> When/why does the key differ?
>
> Why is it not needed/present in 2.4/trunk?
The cache_try_lock API changed between 2.2.x and 2.4.x/trunk. This is fixed in trunk
(r1597533) but a backport to 2.4.x is missing.
The keys can differ in case of Vary headers for the stale entry.
Regards
Rüdiger
Re: svn commit: r1597706 - /httpd/httpd/branches/2.2.x/STATUS
Posted by Eric Covener <co...@gmail.com>.
> + * mod_cache, mod_disk_cache: Try to use the key of a possible open but
> + stale cache entry if there is one. This fixes problem when two different
> + cache locks have been created for single stale cache entry leading to two
> + requests sent to backend.
> + Remove useless apr_file_remove() before renaming the cache entry in
> + mod_disk_cache. This fixes small time-frame during which stale cache
> + entry can be seen as not-cached.
> + PR 50317
> + 2.2.x patch: http://people.apache.org/~jkaluza/patches/httpd-2.2.x-thundering-herd.patch
> +
When/why does the key differ?
Why is it not needed/present in 2.4/trunk?
--
Eric Covener
covener@gmail.com