You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@allura.apache.org by je...@apache.org on 2015/04/16 17:43:52 UTC

[02/22] allura git commit: [#7850] more readable ACL setup

[#7850] more readable ACL setup


Project: http://git-wip-us.apache.org/repos/asf/allura/repo
Commit: http://git-wip-us.apache.org/repos/asf/allura/commit/d503b14a
Tree: http://git-wip-us.apache.org/repos/asf/allura/tree/d503b14a
Diff: http://git-wip-us.apache.org/repos/asf/allura/diff/d503b14a

Branch: refs/heads/ib/6017
Commit: d503b14a1527386dba55cc95c2b8b20d94beb780
Parents: ba7374b
Author: Dave Brondsema <da...@brondsema.net>
Authored: Thu Apr 2 17:24:20 2015 -0400
Committer: Dave Brondsema <da...@brondsema.net>
Committed: Thu Apr 2 17:24:37 2015 -0400

----------------------------------------------------------------------
 ForgeTracker/forgetracker/model/ticket.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/allura/blob/d503b14a/ForgeTracker/forgetracker/model/ticket.py
----------------------------------------------------------------------
diff --git a/ForgeTracker/forgetracker/model/ticket.py b/ForgeTracker/forgetracker/model/ticket.py
index 06626a1..e26f57a 100644
--- a/ForgeTracker/forgetracker/model/ticket.py
+++ b/ForgeTracker/forgetracker/model/ticket.py
@@ -820,8 +820,8 @@ class Ticket(VersionedArtifact, ActivityObject, VotableArtifact):
         if bool_flag:
             role_developer = ProjectRole.by_name('Developer')
             role_creator = ProjectRole.by_user(self.reported_by, upsert=True)
-            _allow_all = lambda role, perms: [
-                ACE.allow(role._id, perm) for perm in perms]
+            def _allow_all(role, perms):
+                return [ACE.allow(role._id, perm) for perm in perms]
             # maintain existing access for developers and the ticket creator,
             # but revoke all access for everyone else
             acl = _allow_all(role_developer, security.all_allowed(self, role_developer))
@@ -839,8 +839,8 @@ class Ticket(VersionedArtifact, ActivityObject, VotableArtifact):
         :param is_disabled: If True, an explicit deny will be created on the discussion thread ACL.
         """
         if is_disabled:
-            _deny_post = lambda role, perms: [ACE.deny(role, perm) for perm in perms]
-            self.discussion_thread.acl = _deny_post(EVERYONE, ('post', 'unmoderated_post'))
+            self.discussion_thread.acl = [ACE.deny(EVERYONE, 'post'),
+                                          ACE.deny(EVERYONE, 'unmoderated_post')]
         else:
             self.discussion_thread.acl = []